Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.10.0 #588

Merged
merged 127 commits into from
Nov 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
127 commits
Select commit Hold shift + click to select a range
3554514
v11.0.0
jonrohan Jun 14, 2018
07413c4
add docs for HTML hidden per #467
shawnbot Aug 23, 2018
be34448
add progress bar module
emilybrick Oct 1, 2018
e574fcb
Make blankslate-narrow responsive
Oct 3, 2018
52e40b7
Make .container responsive
Oct 9, 2018
5b6b30d
progress bar first pass with flex
emilybrick Oct 10, 2018
c8edf4a
removed scss in place of utilities and flex
emilybrick Oct 11, 2018
1650d69
removed utility class and gradient test
emilybrick Oct 11, 2018
3e2ea4c
removed old component
emilybrick Oct 12, 2018
90dec29
removed utility classes component
emilybrick Oct 12, 2018
7511e14
renamed progress bar to progress
emilybrick Oct 12, 2018
95ee7c5
used file: for npm link
emilybrick Oct 15, 2018
777018f
updated name in package.json
emilybrick Oct 16, 2018
2ef4401
updated package-lock.json from remote
emilybrick Oct 16, 2018
9be1ef0
Merge branch 'release-10.9.0' into progress-bar
emilybrick Oct 16, 2018
ac5eb73
Merge branch 'release-10.9.0' into add-hidden-docs
shawnbot Oct 16, 2018
daa86ca
Merge branch 'release-10.9.0' into patch-2
shawnbot Oct 17, 2018
909384f
Merge branch 'release-10.9.0' into patch-1
shawnbot Oct 17, 2018
e74d093
Merge branch 'release-10.9.0' into add-hidden-docs
shawnbot Oct 17, 2018
d347fe4
Merge branch 'release-10.9.0' into progress-bar
emilybrick Oct 18, 2018
816ba94
removed custom scss and removed reverse and inline progress bars
emilybrick Oct 18, 2018
e2114ec
removed tiny styles that werent being applied
emilybrick Oct 18, 2018
d8cc84b
[contributing] fix formatting, nix stylelint step
shawnbot Oct 18, 2018
00b6a84
nix release docs in .github/CONTRIBUTING
shawnbot Oct 18, 2018
f314f9a
move some missing release docs to RELEASING.md
shawnbot Oct 18, 2018
16b37be
update docs link to styleguide
shawnbot Oct 18, 2018
e689adb
remove outdated module path usage
shawnbot Oct 18, 2018
ad285fa
remove stale "Build" section, link to DEVELOP
shawnbot Oct 18, 2018
88b069f
add DEVELOP.md
shawnbot Oct 18, 2018
fa60dd6
fix install link
shawnbot Oct 18, 2018
5a4b302
hash out more development docs
shawnbot Oct 19, 2018
849bf80
changed default and modifier component names
emilybrick Oct 22, 2018
e5f0556
Merge branch 'release-10.9.0' into progress-bar
emilybrick Oct 22, 2018
02c3f73
Merge branch 'release-10.9.0' into patch-2
shawnbot Oct 22, 2018
2d966c9
update primer .version to 10.10.0-alpha
shawnbot Oct 22, 2018
2f3deed
added small test description
emilybrick Oct 23, 2018
000de89
Merge branch 'release-10.9.0' into progress-bar
shawnbot Oct 23, 2018
90843b8
fixed version mismatch
emilybrick Oct 23, 2018
c1e5a83
fixed documentation markdown
emilybrick Oct 23, 2018
7f2f3ba
Merge branch 'master' into release-10.10.0
shawnbot Oct 23, 2018
b3940bb
Merge branch 'release-10.10.0' into progress-bar
shawnbot Oct 23, 2018
fcefbb0
Merge branch 'release-10.10.0' into contrib-tweaks
shawnbot Oct 23, 2018
aa511bd
Merge pull request #585 from primer/contrib-tweaks
shawnbot Oct 23, 2018
e25630e
add fs-extra to primer-module-build.dependencies
shawnbot Oct 23, 2018
96bc268
Merge branch 'release-10.10.0' into module-build-deps
shawnbot Oct 23, 2018
14f2560
Merge branch 'release-10.10.0' into patch-1
shawnbot Oct 23, 2018
46ff3cd
Merge branch 'release-10.10.0' into patch-2
shawnbot Oct 23, 2018
370274c
Merge pull request #591 from primer/module-build-deps
shawnbot Oct 23, 2018
862e83a
remove --dry-run flag from script/release-candidate
shawnbot Oct 24, 2018
7df4a17
Merge pull request #571 from crhallberg/patch-2
shawnbot Oct 24, 2018
4cc7c67
Merge pull request #570 from crhallberg/patch-1
shawnbot Oct 24, 2018
4d4bac0
Merge remote-tracking branch 'origin/release-10.10.0' into progress-bar
shawnbot Oct 25, 2018
6a4fb79
kill the package-lock.json files
shawnbot Oct 25, 2018
1f3fe99
use file: specifiers for peer dependencies
shawnbot Oct 25, 2018
ab7c1bc
add back root package-lock
shawnbot Oct 25, 2018
24504b5
fix up script/check-versions
shawnbot Oct 25, 2018
6d7ed5b
remove peerDependencies from marketing-buttons, popover
shawnbot Oct 25, 2018
c8fd568
Merge branch 'release-10.10.0' into add-hidden-docs
shawnbot Oct 26, 2018
3f65afd
update docs for display utils + [hidden]
shawnbot Oct 26, 2018
f3c4d3e
duplicate [hidden]{display:none!important} in primer-utilities
shawnbot Oct 26, 2018
26d39b7
Revert "Make .container responsive"
shawnbot Oct 29, 2018
04fbe82
Merge pull request #594 from primer/revert-571-patch-2
shawnbot Oct 30, 2018
a574add
replace chalk with colorette
shawnbot Nov 7, 2018
919cba8
disable generator-primer-module for now
shawnbot Nov 8, 2018
eda5ed7
rebuild package-lock
shawnbot Nov 8, 2018
647be3f
rebuild package-locks
shawnbot Nov 8, 2018
f9a1946
disable generator-primer-module for now
shawnbot Nov 8, 2018
38aee6e
replace chalk with colorette
shawnbot Nov 7, 2018
ef03786
update react + react-dom
shawnbot Nov 8, 2018
147aaa9
chalk -> colorette
shawnbot Nov 8, 2018
2157206
nix per package package-lock.json
shawnbot Nov 8, 2018
4deb812
bring primer-module-build back into the fold
shawnbot Nov 8, 2018
9d237e6
move primer-support to devDependencies in generator
shawnbot Nov 8, 2018
a60e72c
tell lerna not to create package-lock.json
shawnbot Nov 8, 2018
b1117b4
rework "clean" run-script; add "fresh"
shawnbot Nov 8, 2018
3c5217f
regenerate package-lock.json
shawnbot Nov 8, 2018
769f10b
update DEVELOP.md with new install guidance
shawnbot Nov 8, 2018
9c6e29f
upgrade to es6, add prettier config
shawnbot Nov 8, 2018
3af1845
create classes.json at prepare time
shawnbot Nov 8, 2018
ab21342
add subdir package-lock.json to .gitignore
shawnbot Nov 8, 2018
36ed5a8
disable selector-no-utility in primer-utilities
shawnbot Nov 8, 2018
1dc859c
lint before testing
shawnbot Nov 8, 2018
8a6d6bf
lint
shawnbot Nov 8, 2018
532329d
always prepare in prepublishOnly?
shawnbot Nov 8, 2018
bb8b015
add classes.json to git?
shawnbot Nov 8, 2018
6c39c22
don't run prepare in prepublishOnly
shawnbot Nov 9, 2018
5c4d5b0
Merge branch 'release-10.9.0' into fix-primerize
shawnbot Nov 9, 2018
61a9ab9
kill peer dependencies again
shawnbot Nov 9, 2018
7dbe4c4
exit silently on prefresh failure
shawnbot Nov 9, 2018
d070918
Merge pull request #597 from primer/fix-primerize
shawnbot Nov 9, 2018
622a20b
Remove [hidden] duplication from primer-utilities
shawnbot Nov 13, 2018
0d96a80
Add [hidden][hidden] { display: none !important}
shawnbot Nov 13, 2018
2784f0b
update [hidden] docs
shawnbot Nov 13, 2018
25f0a99
Merge branch 'release-10.10.0' into add-hidden-docs
shawnbot Nov 13, 2018
913ae29
rebuild package-lock
shawnbot Nov 13, 2018
d080e7c
Merge pull request #561 from primer/add-hidden-docs
shawnbot Nov 13, 2018
375c4df
remove npx dependency (bundled w/npm)
shawnbot Nov 13, 2018
3084bf3
kill the package-lock.json files
shawnbot Oct 25, 2018
818efd1
fix up script/check-versions
shawnbot Oct 25, 2018
c9961ab
Merge pull request #593 from primer/fix-dotcom-install
shawnbot Nov 13, 2018
e8d6e16
bring back generator-primer-module in lerna.json
shawnbot Nov 13, 2018
2a0c3ca
nix unused script/bump-rc
shawnbot Nov 13, 2018
4e6ea8c
remove private:true from generator-primer-module
shawnbot Nov 14, 2018
920e2e3
fix .btn-link code comments
shawnbot Nov 15, 2018
28cf2b9
get stories from markdown
shawnbot Nov 15, 2018
683b841
use 2x spacer between button groups
shawnbot Nov 15, 2018
c6c5d98
use variables in button-group.scss
shawnbot Nov 15, 2018
5aaf67c
use inline-flex in button groups
shawnbot Nov 15, 2018
a14762d
add z-index: 1 to active button group items
shawnbot Nov 15, 2018
5e0cabd
lint
shawnbot Nov 15, 2018
1440c5b
Merge remote-tracking branch 'origin/release-10.10.0' into progress-bar
shawnbot Nov 15, 2018
358b8b6
Merge pull request #601 from primer/button-stories
shawnbot Nov 15, 2018
33c9665
Merge branch 'release-10.10.0' into progress-bar
emilybrick Nov 15, 2018
63a1687
updated readme
emilybrick Nov 15, 2018
b91764c
Merge pull request #573 from primer/progress-bar
emilybrick Nov 16, 2018
9ef3a99
remove empty line
shawnbot Nov 17, 2018
157918f
add v11 deprecation notices for page-headers, page-sections, and tables
shawnbot Nov 17, 2018
16337b2
Publish
shawnbot Nov 19, 2018
8d17eba
add Progress component description
shawnbot Nov 19, 2018
dd425ab
use stylelint-config-primer@2.2.11-rc.7 for now :no_good_man:
shawnbot Nov 19, 2018
b260b93
update changelog for 10.10.0
shawnbot Nov 19, 2018
acc1147
Reverting primer-buttons flex group
jonrohan Nov 19, 2018
f9f1ad4
Merge pull request #603 from primer/revert_flex_button_group
shawnbot Nov 19, 2018
4fb8772
use primer variables again
shawnbot Nov 19, 2018
32be065
fix #600 again
shawnbot Nov 19, 2018
3527fc4
Merge pull request #604 from primer/more-btngroup-fixes
shawnbot Nov 19, 2018
a0213f8
fix up changelog
shawnbot Nov 19, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 2 additions & 104 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,110 +71,8 @@ Here are a few things you can do that will increase the likelihood of your pull
- Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
- Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).

## Releasing a new Primer version 🎉

This section is targeted at maintainers of primer, to instruct them on the processes for releasing a new version.

### In `primer/primer`:

1. Find or create a new pull request with a release branch from `master` and name it `release-<version>`.

(CI will publish a release candidate version to npm for branches prefixed with `release`. These version numbers have a `rc.<number>` suffix on them)

For the pull request you can use the following template.

```md
# Primer Minor Release

Tracking Issue for next release: 📦 **0.0.0**
Approximate release date: 📆

### Must

- [ ]

### Should

- [ ]

### Could

- [ ]

----

### Ship checklist

- [ ] Update CHANGELOG
- [ ] Run version bump
- [ ] Update primer.github.io
- [ ] Update github/github
- [ ] Update the style guide
- [ ] Update the release tag note
- [ ] Create a new pull request for the next release

/cc @primer/ds-core
```

2. Go through the tracking issue and make sure everything that should be merged in is merged in.

3. Once your builds finish, click on the details links for the continuous-integration/travis-ci/push build. Expand the `Deploying application` output and you should be able to find an outputted change log here. Copy this and update the [CHANGELOG.md](https://github.com/primer/primer/blob/master/CHANGELOG.md) file.

4. Run the version bump in your terminal: `npm run bump`.

5. Test your changes with the latest release candidate version in the appropriate places (styleguide, storybook, github/github).

6. Once the release PR is approved and you've done necessary testing, merge to `master`. This will trigger a publish to npm.

### In `github/github`:

1. Create a new branch

2. Update the primer version in your terminal `bin/npm install primer@<version>`.

3. Update `stylelint-config-primer` in your terminal to the appropriate version `bin/npm install stylelint-config-primer@latest`.

4. If you need to make changes to github/github due to the Primer release, make a separate branch. When ready, merge that branch into your release branch.

5. Add reviewers.

6. Check that every deleted vendor file has an accompanying updated vendor file and that the version numbers look correct.

7. Test on review-lab.

8. When ready, merge! 🎉


## Other items that need to be done after publishing Primer

#### Update the Style Guide

1. In [github/styleguide](https://github.com/github/styleguide), update `primer` to your newly released version in your terminal:

`npm install primer@latest`

2. Then run: `script/update-primer-docs`.

3. Commit changes, make PR, get it approved, merge! 🚀

#### Update [primer.github.io](primer.github.io)

1. Edit [index.html](https://github.com/primer/primer.github.io/blob/master/index.html) to include the latest version.

#### Update Storybook

1. Pull the latest from master on primer/primer (after merging in release branch).

2. Run `npm run publish-storybook`.

#### Publish release tag

1. Create a new release tag [here](https://github.com/primer/primer/releases/new).

2. Copy the changes from the [CHANGELOG](https://github.com/primer/primer/blob/master/CHANGELOG.md) and paste it into the release notes.

3. Publish 🎉

## Releasing a new Primer version
See [RELEASING.md](../RELEASING.md) for our release process.

## Resources

Expand Down
11 changes: 6 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
*.lerna_backup
*.log
*/*/package-lock.json
.DS_Store
.changelog
.sass-cache
node_modules
*.log
build
_site
*.lerna_backup
.changelog
build
node_modules
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
save=true
save-exact=true
no-package-lock=true
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ after_success:
deploy:
# publish release candidates on release branches
- provider: script
script: script/release-candidate --dry-run
script: script/release-candidate
skip_cleanup: true
on:
branch: release*
Expand Down
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
# 10.10.0

#### :rocket: Enhancement
* [#573](https://github.com/primer/primer/pull/573) Add Progress component. ([@emilybrick](https://github.com/emilybrick))
* [#561](https://github.com/primer/primer/pull/561) Add HTML `hidden` attribute docs, increase `[hidden]` selector specificity. ([@shawnbot](https://github.com/shawnbot) h/t @jonrohan)

#### :bug: Bug Fix
* [#604](https://github.com/primer/primer/pull/604) Fix Button group focus ring z-index issues. ([@shawnbot](https://github.com/shawnbot))
* [#570](https://github.com/primer/primer/pull/570) Make `.blankslate-narrow` responsive. ([@crhallberg](https://github.com/crhallberg))
* [#591](https://github.com/primer/primer/pull/591) Add fs-extra to `primer-module-build.dependencies`. ([@shawnbot](https://github.com/shawnbot))

#### :memo: Documentation
* [#585](https://github.com/primer/primer/pull/585) Improve contributing docs and add DEVELOP.md. ([@shawnbot](https://github.com/shawnbot))

#### :house: Internal
* [#597](https://github.com/primer/primer/pull/597) Fix primerize, add "fresh" run-script, etc. ([@shawnbot](https://github.com/shawnbot))

#### Committers: 3
- Chris Hallberg ([crhallberg](https://github.com/crhallberg))
- Emily Brick ([emilybrick](https://github.com/emilybrick))
- Shawn Allen ([shawnbot](https://github.com/shawnbot))

# 10.9.0
#### :rocket: Enhancement
* [#586](https://github.com/primer/primer/pull/586) Hiding .Counter component when it's empty.. ([@jonrohan](https://github.com/jonrohan))
Expand Down
88 changes: 88 additions & 0 deletions DEVELOP.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# Primer Development

If you've made it this far, **thank you**! We appreciate your contribution, and hope that this document helps you along the way.

## Structure
The project is structured as a [monorepo] made up of lots of small npm modules, many of which depend on each other. We use [Lerna] to manage, version, and publish all of the packages together.

The top-level `package.json` is not published, but tracks common dependencies for developing Primer, and hosts some useful npm [run-scripts]. See the [scripts section](#scripts) for more info.

## Workflow
The typical Primer workflow looks something like this:

1. [Install](#install)
2. [Start Storybook](#storybook)
3. Navigate to the module you're working on and modify the SCSS and/or markdown files.
4. Test your changes in Storybook.
5. Push your work to a new branch to test it on Travis and have it reviewed by the Primer "core" team.

## Install
Run `npm install` to install the npm dependencies and automatically run link all of the local packages together with `npm run bootstrap`.

### Troubleshooting install problems
If you run into trouble installing, it's always best to ensure that you're starting from a clean slate by running the following from the repository root directory:

```sh
npm run fresh
```

If _that_ gives you problems, then you can try manually deleting everything and starting over:

```
rm -rf node_modules
rm -f package-lock.json */*/package-lock.json
npm install
```

**You may need to do this whenever switching between branches with different dependencies, submodules, or versions of Node and/or npm.** The Primer core team generally uses the latest major version of Node (10 as of this writing), but our CI tests run Node 8 and npm 6. You can check which versions you're running with:

```sh
npm --version
node --version
```

## Storybook
Run `npm start` to start up [Storybook], then visit [localhost:3000](http://localhost:3000) to test your work. By default, all `html` code blocks of all `*.md` files in each module will be rendered as stories and listed under the module's name in the left-hand nav. File changes should trigger live reload automatically after a brief delay.

If the package you're working on has a `stories.js`, it probably includes a snippet like this:

```js
const stories = storiesOf('Module name', module)

storiesFromMarkdown(require.context('.', true, /\.md$/))
.forEach(({title, story}) => {
stories.add(title, story)
})
```

This is how we find all of the Markdown files in the package directory and generate stories from their code blocks. Storybook sections are labeled by the first argument to `storiesOf()` (in the above example, "Module name"), and individual stories get their titles from either the previous Markdown heading or the `title` attribute in the fenced code block. See the [`code-blocks` docs](https://npmjs.com/package/code-blocks) and the [`storiesFromMarkdown()` source](./.storybook/lib/storiesFromMarkdown.js) for more info.

## CSS packages
All of the Primer CSS packages live in the [modules](./modules) subdirectory, including the [`primer`](./modules/package) omnibus package.

## Tools
Many tools specific to development of Primer CSS live in the [tools](./tools) subdirectory.

## Scripts
The [`script` directory](./script) houses a collection of scripts that we use to maintain, test, build, and publish packages. Some scripts of note:

* `script/check-imports` compares the list of Primer npm dependencies for each package with SCSS `@import` statements in its source, and warns if any mismatches (dependencies without corresponding imports, or vice-versa) are found.
* `script/compare-published` compares the latest published versions of each Primer CSS package with the `version` field in its local `package.json`, and reports any discrepancies.
* `script/get-packages` lists all of the package subdirectories from both `modules` and `tools` directories, and is useful for iterating in shell scripts:

```sh
for pkg in $(script/get-packages); do
echo $pkg
done
```

If you're looking for more detail, you can also run `npx lerna ls`, which will list the packages by name along with their versions.

Scripts like `lint-scss`, `notify`, and `test-docs` are called from individual packages to run specific common tasks; `npm-run` and `npm-run-all` are used more generally to run monorepo-installed npm utilities within the package directory, and can probably be refactored to simply run [npx].


[monorepo]: https://github.com/babel/babel/blob/master/doc/design/monorepo.md
[Lerna]: https://github.com/lerna/lerna
[run-scripts]: https://docs.npmjs.com/cli/run-script
[Storybook]: https://storybook.js.org/
[npx]: https://www.npmjs.com/package/npx
20 changes: 3 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,35 +46,21 @@ Then, you would import the module with:
@import "primer-navigation/index.scss";
```

Or, while you're figuring out which modules you need, you can import them directly from the `primer` [`modules` directory](./modules) like so:

```scss
@import "primer/modules/primer-navigation/index.css";
```


## Build

For a compiled **CSS** version of this module, an npm script is included that will output a CSS version to `build/build.css`. The built CSS file is also included in the npm package.

```sh
$ npm run build
```
## Development
See [DEVELOP.md](./DEVELOP.md) for development docs.

## Releasing (Staff only)

You can find docs about our release process in [RELEASING.md](./RELEASING.md).

## Documentation

You can read more about primer in the [docs][docs].
Primer CSS documentation is published to the [GitHub Style Guide](https://styleguide.github.com/primer/).

## License

[MIT](./LICENSE) &copy; [GitHub](https://github.com/)

[primer]: https://github.com/primer/primer
[docs]: http://primer.github.io/
[npm]: https://www.npmjs.com/
[install-npm]: https://docs.npmjs.com/getting-started/installing-node
[sass]: http://sass-lang.com/
47 changes: 41 additions & 6 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,56 @@
### In `primer/primer`:


1. Go through the tracking PR and make sure everything that should be merged in is merged in.
1. Go through the tracking PR and make sure everything listed is merged in.

2. To update the change log for your release, click on the details links for the continuous-integration/travis-ci/push build. Expand the `Deploying application` output and copy the change log content. Update the [CHANGELOG.md](https://github.com/primer/primer/blob/master/CHANGELOG.md) file with the change log content from the build.

3. Run the version bump in your terminal: `npm run bump`.
3. Bump the package versions in your terminal:

4. Run `script/check-versions` to double check there are no version conflicts. You may need to update peer dependencies in `primer-popover` and `primer-marketing-buttons`.
```sh
npm run bump
```

4. Run `script/check-versions` to catch any cross-module version mismatches. You may need to update peer dependencies in `primer-popover` and `primer-marketing-buttons`.

5. Test your changes with the latest release candidate version in the appropriate places (styleguide, storybook, github/github).

6. Once the release PR is approved and you've done necessary testing, merge to `master`. This will trigger a publish to npm.
6. Once the release PR is approved and you've done necessary testing, merge to `master`. This will trigger publishing to npm.

7. Create a new release branch for the next release from `master` and name it `release-<version>`. Please use the following template for the PR description:

```md
# Primer [Major|Minor|Patch] Release

Tracking Issue for next release: 📦 **0.0.0**
Approximate release date: 📆 DD/MM/YY

### Must

- [ ]

### Should

- [ ]

### Could

- [ ]

----

### Ship checklist

7. Create a new release branch for the next release from `master` and name it `release-<version>`.
- [ ] Update CHANGELOG
- [ ] Run version bump
- [ ] Update primer.github.io
- [ ] Update github/github
- [ ] Update the style guide
- [ ] Update the release tag note
- [ ] Create a new pull request for the next release

(CI will publish a release candidate version to npm for branches prefixed with `release`. These version numbers have a `rc.<number>` suffix on them)
/cc @primer/ds-core
```


### In `github/github`:
Expand Down
5 changes: 3 additions & 2 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{
"lerna": "2.4.0",
"version": "independent",
"packages": [
"modules/*",
"tools/*"
],
"npmClientArgs": ["--no-package-lock"],
"changelog": {
"repo": "primer/primer",
"labels": {
Expand All @@ -15,6 +17,5 @@
"Tag: Internal": ":house: Internal"
},
"cacheDir": ".changelog"
},
"version": "independent"
}
}
11 changes: 0 additions & 11 deletions modules/primer-alerts/package-lock.json

This file was deleted.

Loading