Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "prepare" npm script that runs "dist" #718

Merged
merged 2 commits into from Mar 13, 2019
Merged

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Mar 11, 2019

This is a fix for one aspect of #715: if a repo/app/project uses a different version of Node than you've used to run npm install in this repo, running npm link will fail because it will attempt to build the CSS using a node-sass binary for the wrong version of Node.

So instead of running dist in our prepare script (which goes away), we run dist in the now-build script. I've tested this in dot-com and confirmed that bin/npm link ../../primer/css works after having run npm install in this repo with a different version of Node. ✨

@shawnbot shawnbot added this to Work in Progress in 📦 Primer CSS release tracking Mar 11, 2019
@shawnbot shawnbot marked this pull request as ready for review March 12, 2019 18:46
@shawnbot shawnbot changed the base branch from master to release-12.2.0 March 12, 2019 18:48
@simurai simurai mentioned this pull request Mar 12, 2019
10 tasks
@simurai simurai merged commit 4a8c79b into release-12.2.0 Mar 13, 2019
📦 Primer CSS release tracking automation moved this from Work in Progress to 💜 Done Mar 13, 2019
@simurai simurai deleted the fix-npm-link branch March 13, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants