New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade stylelint config #753
Conversation
Oof, well this was kind of tricky. My assumption in primer/stylelint-config#25 was that even with The result is that we still get all of the syntax and formatting rules, but we don't enforce "duplicate" selectors or classnames here because this is the source of those values. |
4dd51b6
to
34cef02
Compare
34cef02
to
3ad45c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 😝
I assume we need to add these rules to .stylelintrc.json
because primer/css should be the only exception.
This PR is a placeholder for upgrading to
stylelint-config-primer@6.0.0
once primer/stylelint-config#27 is ready. For now, let's see if the canary release of primer/stylelint-config#25 plays nicely.