Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stylelint config #753

Merged
merged 4 commits into from Apr 16, 2019
Merged

Upgrade stylelint config #753

merged 4 commits into from Apr 16, 2019

Conversation

shawnbot
Copy link
Contributor

This PR is a placeholder for upgrading to stylelint-config-primer@6.0.0 once primer/stylelint-config#27 is ready. For now, let's see if the canary release of primer/stylelint-config#25 plays nicely.

@shawnbot
Copy link
Contributor Author

Oof, well this was kind of tricky. My assumption in primer/stylelint-config#25 was that even with @primer/css as a peer dependency, it (Node) would still be able to resolve everything when run within that package. This was a bad assumption, so what I ended up doing was disabling both the primer/selector-no-utility and selector/no-override rules in this repo's stylelint config.

The result is that we still get all of the syntax and formatting rules, but we don't enforce "duplicate" selectors or classnames here because this is the source of those values.

@shawnbot shawnbot marked this pull request as ready for review April 11, 2019 19:03
@shawnbot shawnbot added this to Ready to release in 📦 Primer CSS release tracking Apr 15, 2019
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😝

I assume we need to add these rules to .stylelintrc.json because primer/css should be the only exception.

@simurai simurai changed the base branch from master to release-12.2.3 April 16, 2019 00:01
@simurai simurai merged commit f062e1d into release-12.2.3 Apr 16, 2019
📦 Primer CSS release tracking automation moved this from Ready to release to 💜 Done Apr 16, 2019
@simurai simurai deleted the upgrade-stylelint-config branch April 16, 2019 00:01
@simurai simurai mentioned this pull request Apr 16, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants