Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typos #9

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Fixed typos #9

merged 1 commit into from
Mar 27, 2015

Conversation

pborreli
Copy link
Contributor

No description provided.

@pborreli pborreli mentioned this pull request Mar 23, 2015
Closed
@cvrebert cvrebert mentioned this pull request Mar 23, 2015
Closed
carlosantoniodasilva
carlosantoniodasilva reviewed Mar 23, 2015
View reviewed changes
scss/_buttons.scss
@@ -170,7 +170,7 @@

// Octicon buttons
//
// Improve alignemnt of Octicons within buttons and minibuttons. Also auto tweak
// Improve alignement of Octicons within buttons and minibuttons. Also auto tweak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, thx !, fixing it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

@reidrac reidrac mentioned this pull request Mar 24, 2015
Closed
@mdo mdo added the docs label Mar 24, 2015
mdo added a commit that referenced this pull request Mar 24, 2015
@mdo
fixes #39, #35, part of #9: direction in tooltips docs
95308ad
@pborreli
Copy link
Contributor Author

is there an issue with this PR ? do I need to do something before it's accepted ?

@nickmccurdy
Copy link
Contributor

👍 Looks good to me.

@mdo mdo added this to the v2.0.3 milestone Mar 27, 2015
@mdo
Copy link
Contributor

mdo commented Mar 27, 2015

Howdy—thanks for the pull request, @pborreli!

Before we can merge your changes, we need you to review our Contributor License Agreement (CLA). We think of CLAs as an open source software license between you and the project, letting us and other users know that we have permission to use the code you contribute.

At the bottom of the pull request, you'll see the note about a failed test. Just click the Details link, review the CLA, and sign off at the bottom.

Questions? Just holler—I'm here to help :).

<3

@mdo mdo mentioned this pull request Mar 27, 2015
Closed
@pborreli
Copy link
Contributor Author

done

@pborreli
Copy link
Contributor Author

wow i generally don't like CLA but how it is integrated here makes it so easy !

@mdo
Copy link
Contributor

mdo commented Mar 27, 2015

Woohoo, and thank you for the changes!

mdo added a commit that referenced this pull request Mar 27, 2015
@mdo
Merge pull request #9 from pborreli/typos
ff8d28f 
Fixed typos
@mdo mdo merged commit ff8d28f into primer:master Mar 27, 2015
@mdo mdo mentioned this pull request Mar 27, 2015
Closed
@pborreli pborreli deleted the typos branch March 28, 2015 01:58
shawnbot pushed a commit that referenced this pull request Oct 9, 2017
@jonrohan
Merge pull request #9 from primer/greenkeeper-ava-0.17.0
543a8d7 
Update ava to version 0.17.0 🚀
emilybrick pushed a commit that referenced this pull request Oct 4, 2018
@shawnbot
Merge pull request #9 from primer/fix-alias
df3ce59 
Fix aliasing, scale 1x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pborreli @nickmccurdy @mdo @carlosantoniodasilva