Remove "Segoe UI Symbol" from font stack #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-segoe-ui-symbol.primer.now.sh |
|
I tagged this as |
|
Ok, I'm gonna merge this already into #905 and we can keep it as the only change. So that we don't have to test anything else. |
This was referenced Sep 24, 2019
sindresorhus
added a commit
to sindresorhus/modern-normalize
that referenced
this pull request
Dec 23, 2019
See the explanation in primer/css#906
7 tasks
This was referenced Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
Segoe UI Symbolfrom the$body-fontstack.Reasoning
See issue https://github.com/github/design-systems/issues/710 and more specifically this comment https://github.com/github/design-systems/issues/710#issuecomment-533818820.
In short
Segoe UI Symbolis used as a fallback for native emoji support. RemovingSegoe UI Symbolallows users to have other fonts that use the same "private" unicode characters. For example to display certain chinese symbols.Concerns
I think it's only an issue for people still on Windows 7 and only affects non-markdown areas on dotcom.. like the title of an issue.
/cc @muan @primer/ds-core