Fix Box--overlay example #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/l7tx0sq5m |
shawnbot
approved these changes
Oct 15, 2019
simurai
moved this from Release backlog
to Ready to release
in 📦 Primer CSS release tracking
This was referenced Dec 13, 2022
This was referenced Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
.Box--overlayexample by:<svg>for the octicon..Box--overlaydepends on..frame-exampleclass that then gets used to customize the example. It adds somemin-heightso the dialog doesn't get cut off. It lets us avoid using extra wrapper elements that then might get copy&pasted for use in production. It still shows up in the code part, but it's more separated at the bottom with a warning.Closes #936 (for now)