Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish resolve 14.0.0 merge conflicts #967

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 31, 2019

Sorry... 😩 I tried to rebase master on release-14.0.0 to get the changes from release-13.2.0. But there were some merge conflicts and I think I missed the changes from this commit: 771a9f3

So in this PR I tried to add them back. Did I get that right? script/dist.js got changes in release-14.0.0 through this PR: #952

@vercel
Copy link

vercel bot commented Oct 31, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/2s1k84nti
🌍 Preview: https://primer-css-git-release-1400-merge-conflict.primer.now.sh

@simurai simurai mentioned this pull request Oct 31, 2019
19 tasks
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me! I guess we should have something in place to ensure that the dist/variables.json file gets generated, huh? 😬

@shawnbot shawnbot merged commit 8dc9609 into release-14.0.0 Oct 31, 2019
@shawnbot shawnbot deleted the release-14.0.0-merge-conflict branch October 31, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants