Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate variables in 14.0.0 #973

Merged
merged 7 commits into from Nov 5, 2019
Merged

Deprecate variables in 14.0.0 #973

merged 7 commits into from Nov 5, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Nov 4, 2019

This formally deletes the following variable declarations:

  • $marketingSpacers and $allSpacers (use $marketing-spacers and $marketing-all-spacers instead)
  • $status-pending
  • $repo-private-text, $repo-private-bg, and $repo-private-icon
  • $highlight-yellow
  • $exploregrid-item-border-radius
  • $stats-switcher-py
  • $stats-viewport-height
  • $min_tab_size, $max_tab_size

I also had to make two fixes on the tool side:

  1. script/dist.js now includes marketing variables dist/variables.json (so that we can compare them in script/test-deprecations.js)
  2. script/test-deprecations.js doesn't throw an error if a variable that was supposed to be deprecated and doesn't exist in the most recent version of Primer. This is the case with all of our marketing variables, because we weren't previously publishing marketing variable data. 馃槵

@vercel
Copy link

vercel bot commented Nov 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

馃攳 Inspect: https://zeit.co/primer/primer-css/kzjd0xkqr
馃實 Preview: https://primer-css-git-variable-cleanup.primer.now.sh

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃殺馃憤

@shawnbot shawnbot marked this pull request as ready for review November 5, 2019 00:37
@shawnbot shawnbot merged commit 2e687a8 into release-14.0.0 Nov 5, 2019
@shawnbot shawnbot deleted the variable-cleanup branch November 5, 2019 00:37
@shawnbot shawnbot mentioned this pull request Nov 5, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants