Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the Stylelint guide #989

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add link to the Stylelint guide #989

merged 1 commit into from
Dec 17, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 26, 2019

This adds a link to the Stylelint guide added in https://github.com/github/design-systems/pull/735.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Nov 26, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/8tuw3551r
🌍 Preview: https://primer-css-git-stylelint-guide.primer.now.sh

@simurai simurai moved this from Release backlog to Ready to release in 📦 Primer CSS release tracking Nov 26, 2019
@simurai simurai changed the base branch from master to release-14.1.0 December 17, 2019 00:43
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should pull the whole stylelint file into primer.style instead of linking to it?

It seems like good content to show off to other teams. ⚡️ 😎

@simurai
Copy link
Contributor Author

simurai commented Dec 17, 2019

I wonder if we should pull the whole stylelint file into primer.style instead of linking to it?

Hmm.. Was thinking about that too. But it feels a bit odd talking about scripts used internally for another repo (github/github). If we wanted to show off about it, maybe writing a blog post or doing a talk with demos would be more helpful?

Anyways, I'll merge this for now. It's more meant for Hubbers to point them in the right direction.

@simurai simurai merged commit 1940982 into release-14.1.0 Dec 17, 2019
📦 Primer CSS release tracking automation moved this from Ready to release to 💜 Done Dec 17, 2019
@simurai simurai deleted the stylelint-guide branch December 17, 2019 11:07
@simurai simurai mentioned this pull request Dec 17, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants