Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create empty-states.mdx #58

Closed
wants to merge 10 commits into from
Closed

Create empty-states.mdx #58

wants to merge 10 commits into from

Conversation

zainkho
Copy link
Contributor

@zainkho zainkho commented Aug 8, 2019

Empty States Design Guidelines

What will ship

Opening a PR for Empty State design documentation. From the blankslate documentation branch (which was reverted), I have changed:

  • page title to (the more general) Empty States
  • modified the intro to be more generally discussing empty states
  • characterizing the blankslate component as the main tool of use for creating cohesive empty states rather than focusing the docs on the component
  • removing implementation details from the 'Border' section

Future add-ins

In the future, we need to add guidelines on using illustration blankslates for NUX empty states that feel more educational and market-y rather than informative. See the issue for NUX empty states here.

@zainkho zainkho self-assigned this Aug 8, 2019
@zainkho zainkho mentioned this pull request Aug 8, 2019
@zainkho zainkho requested a review from ashygee August 8, 2019 19:46
Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Zain Khoja and others added 6 commits August 9, 2019 13:22
Updated anatomy to show optional border element
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Adding NUX blankslate documentation
@zainkho
Copy link
Contributor Author

zainkho commented Aug 12, 2019

Merged the NUX empty state documentation

@vercel vercel bot had a problem deploying to staging August 14, 2019 17:12 Failure
@zainkho
Copy link
Contributor Author

zainkho commented Aug 14, 2019

Moving this PR over to a new one using Doctocat 🐱

@zainkho zainkho closed this Aug 14, 2019
@yaili yaili deleted the empty-state-documentation branch April 27, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants