Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated blankslate component #861

Merged
merged 10 commits into from
Aug 12, 2019
Merged

updated blankslate component #861

merged 10 commits into from
Aug 12, 2019

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Aug 8, 2019 •
edited
Loading

This PR updates the blankslate component and addresses #860 :

  • updated examples to add pictograms, primary action button, and secondary action link
  • removed background and box-shadow inset
  • updated no border version to use border-0 utility

Related docs PRs:
primer/design #55
primer/design #58

Design:
Original design issue covers background and links to figma files.

Screenshot:
Screenshot 2019-08-08 15 46 58

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Aug 8, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

emplums
emplums suggested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments! I just left some comments on the first example of the blankslate, but all the subsequent examples will need the same changes. Let me know if you have any questions! 💖

pages/css/components/blankslate.md Outdated Show resolved Hide resolved
pages/css/components/blankslate.md Outdated Show resolved Hide resolved
pages/css/components/blankslate.md Show resolved Hide resolved
pages/css/components/blankslate.md Show resolved Hide resolved
pages/css/components/blankslate.md Outdated Show resolved Hide resolved
@ashygee
Update pages/css/components/blankslate.md
6770950 
Co-Authored-By: Emily <emplums@github.com>
@vercel vercel bot temporarily deployed to staging August 9, 2019 17:13 Inactive
@zainkho zainkho mentioned this pull request Aug 9, 2019
Closed
@ashygee ashygee requested a review from emplums August 9, 2019 18:39
@vercel vercel bot temporarily deployed to staging August 9, 2019 18:46 Inactive
@ashygee
add warning symbol
47a9a72 
Co-Authored-By: Emily <emplums@github.com>
jonrohan
jonrohan approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. 👍🏻

@ashygee ashygee requested a review from emplums August 9, 2019 22:38
@ashygee ashygee merged commit 6f4e0e5 into release-12.6.0 Aug 12, 2019
@shawnbot shawnbot mentioned this pull request Aug 12, 2019
Merged
11 tasks
@shawnbot shawnbot deleted the blankslate-update branch August 19, 2019 18:25
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 14, 2022
Open
Open
This was referenced Jan 8, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@emplums emplums Awaiting requested review from emplums

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashygee @jonrohan @emplums