Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Light Default terminal contrast #157

Closed
zepfietje opened this issue Apr 16, 2021 · 1 comment · Fixed by #160
Closed

GitHub Light Default terminal contrast #157

zepfietje opened this issue Apr 16, 2021 · 1 comment · Fixed by #160

Comments

@zepfietje
Copy link

Terminal colors for the GitHub Light Default theme have too little contrast (e.g. gray is barely readable).

Not sure if this is intended or not, because the dark theme does look good.

@maxxscho
Copy link

I think some colors are too dark since the changes in #160 .
For example yellow and green. I use the Agnoster Theme of Oh-my-zsh which has some backgrounds. Yellow in combination with the black font isn't readable anymore.

Github Light Default
image

Github Light (classic)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants