Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terminal colors (GitHub Light Default) #160

Merged
merged 1 commit into from Apr 19, 2021
Merged

Fix terminal colors (GitHub Light Default) #160

merged 1 commit into from Apr 19, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Apr 19, 2021 •
edited

This bumps @primer/primitives to 4.2.2. It includes primer/primitives#73 and should fix the low contrast of the terminal colors in GitHub Light Default:

Before After
Screen Shot 2021-04-19 at 13 58 27 Screen Shot 2021-04-19 at 13 43 14

Fixes #157
Fixes #155

@simurai simurai merged commit 6dae51a into master Apr 19, 2021
@simurai simurai deleted the bump-primitives branch April 19, 2021 06:45
@dominicegginton dominicegginton mentioned this pull request Apr 20, 2021
Closed
@maxxscho maxxscho mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Light Default terminal contrast [Terminal] Arguments passed are extremely hard to see (Screenshot)
1 participant
@simurai