Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic token highlighting #326

Open
charconstpointer opened this issue Sep 23, 2022 · 5 comments · Fixed by #337
Open

Semantic token highlighting #326

charconstpointer opened this issue Sep 23, 2022 · 5 comments · Fixed by #337
Labels
type: syntax Syntax highlighting

Comments

@charconstpointer
Copy link

charconstpointer commented Sep 23, 2022

It seems like this theme does not support semantic highlighting https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide

Github Theme with "gopls": { "ui.semanticTokens": true }

Screenshot 2022-09-24 at 00 51 31

Dark+ with "gopls": { "ui.semanticTokens": true }

Screenshot 2022-09-24 at 00 51 24

Dark+ with "gopls": { "ui.semanticTokens": false }

Screenshot 2022-09-24 at 00 51 08

Will this be supported in the future?

@charconstpointer charconstpointer changed the title Golang token highlighting when using go extension Semantic token highlighting Sep 23, 2022
@ShadiestGoat
Copy link
Contributor

Yes I came here for the exact same reason - %v in go strings is not highlighted!

@ShadiestGoat
Copy link
Contributor

I believe that there is actual support for semantic highlighting to some extent actually! On GitHub Dark Default, are differences between a regular string and %v,
image

It is just very low contrast

@ShadiestGoat
Copy link
Contributor

image
image

@soraros
Copy link

soraros commented Jan 2, 2023

@simurai I think this issue is not closed with #337 alone.

@simurai
Copy link
Contributor

simurai commented Jan 3, 2023

I think this issue is not closed with #337 alone.

Ohh.. ok. Let's reopen it for further improvements.

@simurai simurai reopened this Jan 3, 2023
@simurai simurai added this to 📮 Inbox in 🐞 GitHub theme issue tracking via automation Jan 6, 2023
@simurai simurai added the type: syntax Syntax highlighting label Jan 6, 2023
@simurai simurai moved this from 📮 Inbox to Syntax in 🐞 GitHub theme issue tracking Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: syntax Syntax highlighting
Development

Successfully merging a pull request may close this issue.

4 participants