Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better placeholder colors for semantic highlighting #337

Merged
merged 2 commits into from Jan 2, 2023

Conversation

ShadiestGoat
Copy link
Contributor

This helps close #326. The change affects go (golang), python, and possibly others. The changes will make variables inside of strings (placeholders) more visible. Below is a demo of that.

Before

Go

image

Python

image

After

Go

image

Python

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

🦋 Changeset detected

Latest commit: 60db748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ShadiestGoat
Copy link
Contributor Author

Do I have to do change sets myself or is this the job of the maintainers?

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. 👍

Do I have to do change sets myself or is this the job of the maintainers?

Either is fine. I'll add a changeset now and merge this. 🙇 Should get released in the next few days.

@simurai simurai merged commit 68aef06 into primer:main Jan 2, 2023
@primer-css primer-css mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic token highlighting
2 participants