Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some colors are hard to differentiate #69

Closed
bao007fei opened this issue Jun 26, 2020 · 2 comments · Fixed by #303
Closed

Some colors are hard to differentiate #69

bao007fei opened this issue Jun 26, 2020 · 2 comments · Fixed by #303

Comments

@bao007fei
Copy link

Really love this theme. How about add some more color contrast in such cases. Thanks:D

image
image

@simurai simurai added this to 📮 Inbox in 🐞 GitHub theme issue tracking via automation Jun 27, 2020
@simurai
Copy link
Contributor

simurai commented Jun 27, 2020

This came up a few times.. #19 + #20 + #56. And there is a PR trying to fix it: #54.

Here the comment from that PR:

But I'm not sure if it's fixable without also fixing github.com's syntax highlighting. 🤔 So far this theme was built with these restrictions:

  1. Keep the colors to github.com as close as possible.
  2. Keep the same hue for the light and dark version.

We could disregard the two restrictions and experiment with different colors, but might be safer to initially do that as a separate theme that isn't used for Codespaces.

So yeah, we would have to diverge from the syntax highlighting on github.com or maybe better yet: Change it in the VS Code theme AND on github.com.

@simurai simurai moved this from 📮 Inbox to 🤔 In limbo in 🐞 GitHub theme issue tracking Jun 27, 2020
This was referenced Jun 27, 2020
@bao007fei
Copy link
Author

This came up a few times.. #19 + #20 + #56. And there is a PR trying to fix it: #54.

Here the comment from that PR:

But I'm not sure if it's fixable without also fixing github.com's syntax highlighting. 🤔 So far this theme was built with these restrictions:

  1. Keep the colors to github.com as close as possible.
  2. Keep the same hue for the light and dark version.

We could disregard the two restrictions and experiment with different colors, but might be safer to initially do that as a separate theme that isn't used for Codespaces.

So yeah, we would have to diverge from the syntax highlighting on github.com or maybe better yet: Change it in the VS Code theme AND on github.com.

Thanks for the info. I would like to embrace the changes, both of them:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants