Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize JSON property-name #303

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Colorize JSON property-name #303

merged 2 commits into from
Jul 15, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 15, 2022

This changes the property-name in JSON files to green and should make it easier to see the "value":

Before After
Screen Shot 2022-07-15 at 14 34 44 Screen Shot 2022-07-15 at 14 39 24
Screen Shot 2022-07-15 at 14 35 32 Screen Shot 2022-07-15 at 14 36 43

Reasoning

We have been holding off with this change mainly to stay close to github.com, but it now seems things changed and the property names in JSON files are now green. E.g. https://github.com/primer/github-vscode-theme/blob/main/package.json So it makes sense this theme follows up with the same change.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2022

🦋 Changeset detected

Latest commit: 735ec3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/dark-colorblind.json	2022-07-15 05:53:18.707955164 +0000
@@ -460,2 +460,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#83d4ff"
+      }
+    },
+    {
       "scope": "meta.module-reference",
--- base/themes/dark-default.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/dark-default.json	2022-07-15 05:53:18.707955164 +0000
@@ -460,2 +460,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#7ee787"
+      }
+    },
+    {
       "scope": "meta.module-reference",
--- base/themes/dark-dimmed.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/dark-dimmed.json	2022-07-15 05:53:18.707955164 +0000
@@ -460,2 +460,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#8ddb8c"
+      }
+    },
+    {
       "scope": "meta.module-reference",
--- base/themes/dark-high-contrast.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/dark-high-contrast.json	2022-07-15 05:53:18.707955164 +0000
@@ -464,2 +464,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#72f088"
+      }
+    },
+    {
       "scope": "meta.module-reference",
--- base/themes/light-colorblind.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/light-colorblind.json	2022-07-15 05:53:18.707955164 +0000
@@ -445,2 +445,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#054da9"
+      }
+    },
+    {
       "scope": "meta.module-reference",
--- base/themes/light-default.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/light-default.json	2022-07-15 05:53:18.707955164 +0000
@@ -445,2 +445,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#116329"
+      }
+    },
+    {
       "scope": "meta.module-reference",
--- base/themes/light-high-contrast.json	2022-07-15 05:53:21.063946332 +0000
+++ themes/light-high-contrast.json	2022-07-15 05:53:18.707955164 +0000
@@ -448,2 +448,8 @@
     {
+      "scope": "support.type.property-name.json",
+      "settings": {
+        "foreground": "#024c1a"
+      }
+    },
+    {
       "scope": "meta.module-reference",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant