Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Dark to match github.com #102

Merged
merged 26 commits into from Jan 20, 2021
Merged

Update GitHub Dark to match github.com #102

merged 26 commits into from Jan 20, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jan 8, 2021 •
edited

github.com now has an official dark mode. To keep this theme close to github.com, this PR does the following:

GitHub Light GitHub Dark
light dark

Closes #103

simurai and others added 26 commits December 10, 2020 16:24
@simurai
Add SpaceGray theme
e0daad2 
The plan is:

1. Rename "GitHub Dark" to "GitHub SpaceGray"
2. Use new dark colors for "GitHub Dark"
@simurai
Rename style to mode
7d0cb6d 
Not sure if this is a better name, but it relates to what VS Code calls "uiTheme".
@simurai
Add "theme" parameter
7b13e6a
@simurai
Rename primer to colors
aa18f7b
@simurai
Update guide
e9adb70
@simurai
Add SpaceGray colors
a355759
@simurai
Indent
4000b65
@simurai
Use new colors from @primer/primitives
1cf816a
@simurai @borisimple
sync dark colors with new official dark theme
2b069bf 
Co-Authored-By: Boris Krstic <borisimple@gmail.com>
@simurai
Invert Dark colors
39dcc73
@simurai
Tweak Dark colors
85fcede
@simurai
Refactor
8dc2de5
@simurai
Update Dark editorLineNumber
6285b33
@simurai
Update Dark text colors
0c9ad08
@simurai
Tweak Dark colors
ab5552d
@simurai
Add Dimmed theme
fede548
@simurai
Update Dimmed border color
a3e467a
@simurai
Bump Dimmed editor text
f424f98
@simurai
Remove SpaceGray
3192fc6
@simurai
Use all colors
7be7c47
@simurai
Use functional variables
85a8669
@simurai
Use more functional variables
3e9d9eb
@simurai
Switch to chroma-js
dae606f 
So we can use the `#RRGGBBAA` format that VS Code needs.
@simurai
Convert rgba() to #RRGGBBAA
7cee89c
@simurai
Fix textCodeBlock.background
66bc8f0
@simurai
Hide Dimmed theme
2c64c3b 
for now
@simurai simurai added this to 🔍 Ready for review in 📦 GitHub theme release tracking via automation Jan 8, 2021
@simurai simurai mentioned this pull request Jan 9, 2021
Closed
dominicegginton
dominicegginton approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@dominicegginton dominicegginton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will be nice once merged and released to get consistent theme across vscode, codespaces and GitHub.com

@jazg
Copy link

jazg commented Jan 12, 2021 •
edited

@simurai Will this be available for use soon?

@HDenizD
Copy link

HDenizD commented Jan 13, 2021 •
edited

Wake up @simurai, we have a theme to merge! 👓 😆
giphy

@simurai simurai moved this from 🔍 Ready for review to ✅ Approved for release in 📦 GitHub theme release tracking Jan 20, 2021
@simurai simurai merged commit c4a98a6 into master Jan 20, 2021
📦 GitHub theme release tracking automation moved this from ✅ Approved for release to 💜 Done Jan 20, 2021
@simurai simurai deleted the dark branch January 20, 2021 03:16
@simurai
Copy link
Contributor Author

simurai commented Jan 20, 2021

ok, this should now be published as 2.0.0 🤖 .

@simurai
Copy link
Contributor Author

simurai commented Jan 20, 2021 •
edited

For those that prefer the "old" dark theme, you can still install it via .vsix from the github-vscode-theme-dark-classic repo. See Install in the README. It should appear as GitHub Dark Classic.

Screen Shot 2021-01-20 at 13 36 03

Note that we don't plan to update it any further. But if someone wants to fork and maintain it, that's cool too.

In the future we plan to add more themes, here a "dimmed" version that we still have to finalize a bit more: #105

@jaycverg
Copy link

Good thing there is the "Dark Classic" :D

@musab
Copy link

musab commented Jan 20, 2021

The new theme is awesome! Thank you for your all your hard work @simurai! 🙏

@ahmed2m
Copy link

ahmed2m commented Jan 20, 2021

New theme is very contrast-y compared to old one with the very bright line separators between sections. Thanks for providing a version to fallback to but it's sad that it won't be maintained :/

@tjeastmond
Copy link

Have to say the new dark mode is disappointing compared to the original. I appreciate the hard work though.

@jsg2021
Copy link

jsg2021 commented Jan 20, 2021 •
edited

New theme is very contrast-y compared to old one with the very bright line separators between sections. Thanks for providing a version to fallback to but it's sad that it won't be maintained :/

Hard same. I Loved the previous one... It got me off Atom & it's One Dark theme... Looking forward to the Dim merge...

@dpunish3r
Copy link

Dark theme original was better. Please keep the 3 themes.

@devdammit
Copy link

New theme is awesome! Thanks for all your work. 🤘

But original dark theme was so pretty and concise, IMHO. 😌

@Couapy
Copy link

Couapy commented Jan 21, 2021

Oww.. Can you support the old dark theme ? I really prefer it but I don't really want to install the VSIX file.
Thank you a lot !

@simurai
Copy link
Contributor Author

simurai commented Jan 21, 2021

Can you support the old dark theme ? I really prefer it but I don't really want to install the VSIX file.

@BerriJ published it to the marketplace.

@simurai simurai mentioned this pull request Jan 22, 2021
Closed
simurai added a commit that referenced this pull request Jan 23, 2021
@simurai
Revert "Merge pull request #102 from primer/dark"
795b222 
This reverts commit c4a98a6, reversing
changes made to 7e4192f.
@simurai simurai mentioned this pull request Jan 25, 2021
Merged
@evanrelf evanrelf mentioned this pull request Jan 27, 2021
Open
@simurai simurai mentioned this pull request Feb 2, 2021
Merged
2 tasks
@simurai simurai mentioned this pull request Mar 22, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonameolsson nonameolsson nonameolsson approved these changes

@dominicegginton dominicegginton dominicegginton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
📦 GitHub theme release tracking
  
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme and text highlight not matching the new Github website dark theme