Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diff colors #287

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Improve diff colors #287

merged 2 commits into from
Jul 12, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 12, 2022

This improves the diff colors by making changed text stand out against the background. E.g. 3 changed to 8:

Before After
Screen Shot 2022-07-12 at 15 32 52 Screen Shot 2022-07-12 at 16 58 43

Also the diff colors are now semi-transparent so that selection can be seen:

Before After
Screen Shot 2022-07-12 at 15 33 17 Screen Shot 2022-07-12 at 16 58 59

Fixes #287

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

🦋 Changeset detected

Latest commit: dd81ff1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/dark-colorblind.json	2022-07-12 08:06:25.991474685 +0000
@@ -130,4 +130,6 @@
     "editorGutter.deletedBackground": "#c3800066",
-    "diffEditor.insertedTextBackground": "#1585fd26",
-    "diffEditor.removedTextBackground": "#c3800026",
+    "diffEditor.insertedLineBackground": "#1d69e033",
+    "diffEditor.insertedTextBackground": "#1d69e04d",
+    "diffEditor.removedLineBackground": "#a6690033",
+    "diffEditor.removedTextBackground": "#a669004d",
     "scrollbar.shadow": "#484f5833",
--- base/themes/dark-default.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/dark-default.json	2022-07-12 08:06:25.991474685 +0000
@@ -130,4 +130,6 @@
     "editorGutter.deletedBackground": "#f8514966",
-    "diffEditor.insertedTextBackground": "#2ea04326",
-    "diffEditor.removedTextBackground": "#f8514926",
+    "diffEditor.insertedLineBackground": "#23863633",
+    "diffEditor.insertedTextBackground": "#2386364d",
+    "diffEditor.removedLineBackground": "#da363333",
+    "diffEditor.removedTextBackground": "#da36334d",
     "scrollbar.shadow": "#484f5833",
--- base/themes/dark-dimmed.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/dark-dimmed.json	2022-07-12 08:06:25.991474685 +0000
@@ -130,4 +130,6 @@
     "editorGutter.deletedBackground": "#e5534b66",
-    "diffEditor.insertedTextBackground": "#46954a26",
-    "diffEditor.removedTextBackground": "#e5534b26",
+    "diffEditor.insertedLineBackground": "#347d3933",
+    "diffEditor.insertedTextBackground": "#347d394d",
+    "diffEditor.removedLineBackground": "#c93c3733",
+    "diffEditor.removedTextBackground": "#c93c374d",
     "scrollbar.shadow": "#545d6833",
--- base/themes/dark-high-contrast.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/dark-high-contrast.json	2022-07-12 08:06:25.991474685 +0000
@@ -131,4 +131,6 @@
     "editorGutter.deletedBackground": "#ff6a69",
-    "diffEditor.insertedTextBackground": "#09b43a26",
-    "diffEditor.removedTextBackground": "#ff6a6926",
+    "diffEditor.insertedLineBackground": "#09b43a33",
+    "diffEditor.insertedTextBackground": "#09b43a4d",
+    "diffEditor.removedLineBackground": "#ff6a6933",
+    "diffEditor.removedTextBackground": "#ff6a694d",
     "scrollbar.shadow": "#7a828e33",
--- base/themes/light-colorblind.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/light-colorblind.json	2022-07-12 08:06:25.991474685 +0000
@@ -130,4 +130,6 @@
     "editorGutter.deletedBackground": "#e7a10066",
-    "diffEditor.insertedTextBackground": "#c0f6ff",
-    "diffEditor.removedTextBackground": "#fefe48",
+    "diffEditor.insertedLineBackground": "#96e5ff4d",
+    "diffEditor.insertedTextBackground": "#65ccff66",
+    "diffEditor.removedLineBackground": "#fee3254d",
+    "diffEditor.removedTextBackground": "#f8c20066",
     "scrollbar.shadow": "#6e778133",
--- base/themes/light-default.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/light-default.json	2022-07-12 08:06:25.991474685 +0000
@@ -130,4 +130,6 @@
     "editorGutter.deletedBackground": "#ff818266",
-    "diffEditor.insertedTextBackground": "#dafbe1",
-    "diffEditor.removedTextBackground": "#ffebe9",
+    "diffEditor.insertedLineBackground": "#aceebb4d",
+    "diffEditor.insertedTextBackground": "#6fdd8b66",
+    "diffEditor.removedLineBackground": "#ffcecb4d",
+    "diffEditor.removedTextBackground": "#ffaba866",
     "scrollbar.shadow": "#6e778133",
--- base/themes/light-high-contrast.json	2022-07-12 08:06:28.783517083 +0000
+++ themes/light-high-contrast.json	2022-07-12 08:06:25.991474685 +0000
@@ -130,4 +130,6 @@
     "editorGutter.deletedBackground": "#ee5a5d",
-    "diffEditor.insertedTextBackground": "#d2fedb",
-    "diffEditor.removedTextBackground": "#fff0ee",
+    "diffEditor.insertedLineBackground": "#82e5964d",
+    "diffEditor.insertedTextBackground": "#43c66366",
+    "diffEditor.removedLineBackground": "#ffc1bc4d",
+    "diffEditor.removedTextBackground": "#ff8e8a66",
     "scrollbar.shadow": "#67707a33",

@simurai simurai merged commit fb89288 into main Jul 12, 2022
@simurai simurai deleted the improve-diff branch July 12, 2022 08:20
@primer-css primer-css mentioned this pull request Jul 12, 2022
@simurai simurai mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant