Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selection in High Contrast themes #294

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Improve selection in High Contrast themes #294

merged 2 commits into from
Jul 14, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 14, 2022

This closes #271 by making sure the background in High Contrast themes has enough contrast.

Before After
Screen Shot 2022-07-14 at 14 35 34 Screen Shot 2022-07-14 at 15 16 59
Screen Shot 2022-07-14 at 15 17 59 Screen Shot 2022-07-14 at 15 14 34

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: 5593a09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/dark-colorblind.json	2022-07-14 06:23:14.430869467 +0000
@@ -118,4 +118,2 @@
     "editor.linkedEditingBackground": "#58a6ff12",
-    "editor.inactiveSelectionBackground": "#58a6ff12",
-    "editor.selectionBackground": "#58a6ff33",
     "editor.selectionHighlightBackground": "#42a0ff40",
--- base/themes/dark-default.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/dark-default.json	2022-07-14 06:23:14.430869467 +0000
@@ -118,4 +118,2 @@
     "editor.linkedEditingBackground": "#58a6ff12",
-    "editor.inactiveSelectionBackground": "#58a6ff12",
-    "editor.selectionBackground": "#58a6ff33",
     "editor.selectionHighlightBackground": "#3fb95040",
--- base/themes/dark-dimmed.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/dark-dimmed.json	2022-07-14 06:23:14.430869467 +0000
@@ -118,4 +118,2 @@
     "editor.linkedEditingBackground": "#539bf512",
-    "editor.inactiveSelectionBackground": "#539bf512",
-    "editor.selectionBackground": "#539bf533",
     "editor.selectionHighlightBackground": "#57ab5a40",
--- base/themes/dark-high-contrast.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/dark-high-contrast.json	2022-07-14 06:23:14.430869467 +0000
@@ -119,4 +119,4 @@
     "editor.linkedEditingBackground": "#71b7ff12",
-    "editor.inactiveSelectionBackground": "#71b7ff12",
-    "editor.selectionBackground": "#71b7ff33",
+    "editor.inactiveSelectionBackground": "#9ea7b3",
+    "editor.selectionBackground": "#ffffff",
     "editor.selectionHighlightBackground": "#26cd4d40",
@@ -128,2 +128,3 @@
     "editorBracketMatch.border": "#26cd4d99",
+    "editor.selectionForeground": "#0a0c10",
     "editorInlayHint.background": "#bdc4cc33",
--- base/themes/light-colorblind.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/light-colorblind.json	2022-07-14 06:23:14.430869467 +0000
@@ -118,4 +118,2 @@
     "editor.linkedEditingBackground": "#0969da12",
-    "editor.inactiveSelectionBackground": "#0969da12",
-    "editor.selectionBackground": "#0969da33",
     "editor.selectionHighlightBackground": "#35adff40",
--- base/themes/light-default.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/light-default.json	2022-07-14 06:23:14.430869467 +0000
@@ -118,4 +118,2 @@
     "editor.linkedEditingBackground": "#0969da12",
-    "editor.inactiveSelectionBackground": "#0969da12",
-    "editor.selectionBackground": "#0969da33",
     "editor.selectionHighlightBackground": "#4ac26b40",
--- base/themes/light-high-contrast.json	2022-07-14 06:23:17.054858502 +0000
+++ themes/light-high-contrast.json	2022-07-14 06:23:14.430869467 +0000
@@ -118,4 +118,4 @@
     "editor.linkedEditingBackground": "#0349b412",
-    "editor.inactiveSelectionBackground": "#0349b412",
-    "editor.selectionBackground": "#0349b433",
+    "editor.inactiveSelectionBackground": "#67707a",
+    "editor.selectionBackground": "#24292f",
     "editor.selectionHighlightBackground": "#26a14840",
@@ -127,2 +127,3 @@
     "editorBracketMatch.border": "#26a14899",
+    "editor.selectionForeground": "#ffffff",
     "editorInlayHint.background": "#acb6c033",

@simurai simurai merged commit af2eecc into main Jul 14, 2022
@simurai simurai deleted the hc-selection branch July 14, 2022 06:24
@primer-css primer-css mentioned this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad Collor combination on "Dark High Contrast" while marker lines
1 participant