Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve breakpoint icon for colorblind themes #299

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 14, 2022

This closes #245 by using color.danger.fg. It should have the effect that it's red in all themes, except for the color blind themes where it's "orange":

Colorblind themes Other themes
Screen Shot 2022-07-14 at 19 45 27 Screen Shot 2022-07-14 at 19 45 52
Orange Red

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: b0f4bd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/dark-colorblind.json	2022-07-14 10:54:46.562606321 +0000
@@ -149,2 +149,3 @@
     "panelInput.border": "#30363d",
+    "debugIcon.breakpointForeground": "#c38000",
     "debugConsole.infoForeground": "#8b949e",
--- base/themes/dark-default.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/dark-default.json	2022-07-14 10:54:46.562606321 +0000
@@ -149,2 +149,3 @@
     "panelInput.border": "#30363d",
+    "debugIcon.breakpointForeground": "#f85149",
     "debugConsole.infoForeground": "#8b949e",
--- base/themes/dark-dimmed.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/dark-dimmed.json	2022-07-14 10:54:46.562606321 +0000
@@ -149,2 +149,3 @@
     "panelInput.border": "#444c56",
+    "debugIcon.breakpointForeground": "#e5534b",
     "debugConsole.infoForeground": "#768390",
--- base/themes/dark-high-contrast.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/dark-high-contrast.json	2022-07-14 10:54:46.562606321 +0000
@@ -153,2 +153,3 @@
     "panelInput.border": "#7a828e",
+    "debugIcon.breakpointForeground": "#ff6a69",
     "debugConsole.infoForeground": "#bdc4cc",
--- base/themes/light-colorblind.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/light-colorblind.json	2022-07-14 10:54:46.562606321 +0000
@@ -149,2 +149,3 @@
     "panelInput.border": "#d0d7de",
+    "debugIcon.breakpointForeground": "#ac5e00",
     "debugConsole.infoForeground": "#57606a",
--- base/themes/light-default.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/light-default.json	2022-07-14 10:54:46.562606321 +0000
@@ -149,2 +149,3 @@
     "panelInput.border": "#d0d7de",
+    "debugIcon.breakpointForeground": "#cf222e",
     "debugConsole.infoForeground": "#57606a",
--- base/themes/light-high-contrast.json	2022-07-14 10:54:48.930663461 +0000
+++ themes/light-high-contrast.json	2022-07-14 10:54:46.562606321 +0000
@@ -152,2 +152,3 @@
     "panelInput.border": "#30363d",
+    "debugIcon.breakpointForeground": "#a0111f",
     "debugConsole.infoForeground": "#4f5760",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Dark Colorblind theme break point not visible for color blind person
1 participant