Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove punctuation.definition.string #311

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 15, 2022

This closes #133.

punctuation.definition.string should not be needed since it just inherits the color from string anyways.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2022

🦋 Changeset detected

Latest commit: 09968c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/dark-colorblind.json	2022-07-15 07:52:31.906738480 +0000
@@ -340,3 +340,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"
--- base/themes/dark-default.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/dark-default.json	2022-07-15 07:52:31.906738480 +0000
@@ -340,3 +340,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"
--- base/themes/dark-dimmed.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/dark-dimmed.json	2022-07-15 07:52:31.906738480 +0000
@@ -340,3 +340,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"
--- base/themes/dark-high-contrast.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/dark-high-contrast.json	2022-07-15 07:52:31.906738480 +0000
@@ -344,3 +344,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"
--- base/themes/light-colorblind.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/light-colorblind.json	2022-07-15 07:52:31.906738480 +0000
@@ -325,3 +325,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"
--- base/themes/light-default.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/light-default.json	2022-07-15 07:52:31.906738480 +0000
@@ -325,3 +325,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"
--- base/themes/light-high-contrast.json	2022-07-15 07:52:34.318675056 +0000
+++ themes/light-high-contrast.json	2022-07-15 07:52:31.906738480 +0000
@@ -328,3 +328,2 @@
         "string",
-        "punctuation.definition.string",
         "string punctuation.section.embedded source"

@simurai simurai merged commit da7f470 into main Jul 15, 2022
@simurai simurai deleted the punctuation-definition-string branch July 15, 2022 07:53
@primer-css primer-css mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Punctuation.definition.string - Too high priority
1 participant