Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve minimap slider contrast #346

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Improve minimap slider contrast #346

merged 2 commits into from
Jan 5, 2023

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jan 5, 2023

This improves the slider contrast for the minimap. It also keeps it in sync with the editor scrollbars.

Closes #200

Screenshots

Before After
Screen Shot 2023-01-05 at 12 23 15 Screen Shot 2023-01-05 at 12 24 55
Screen Shot 2023-01-05 at 12 16 46 Screen Shot 2023-01-05 at 12 15 57

Merge checklist

  • Added/updated colors
  • Added/updated documentation/README
  • Tested in GitHub Light Default + GitHub Dark Default theme

Take a look at the Contribute section for more information on how test your changes locally.

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

🦋 Changeset detected

Latest commit: 2c27f5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Colors changed
--- base/themes/dark-colorblind.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/dark-colorblind.json	2023-01-05 03:28:04.932188186 +0000
@@ -143,6 +143,9 @@
     "scrollbar.shadow": "#484f5833",
-    "scrollbarSlider.background": "#6e768133",
-    "scrollbarSlider.hoverBackground": "#6e768145",
-    "scrollbarSlider.activeBackground": "#6e768187",
+    "scrollbarSlider.background": "#8b949e33",
+    "scrollbarSlider.hoverBackground": "#8b949e3d",
+    "scrollbarSlider.activeBackground": "#8b949e47",
     "editorOverviewRuler.border": "#010409",
+    "minimapSlider.background": "#8b949e33",
+    "minimapSlider.hoverBackground": "#8b949e3d",
+    "minimapSlider.activeBackground": "#8b949e47",
     "panel.background": "#010409",
--- base/themes/dark-default.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/dark-default.json	2023-01-05 03:28:04.932188186 +0000
@@ -143,6 +143,9 @@
     "scrollbar.shadow": "#484f5833",
-    "scrollbarSlider.background": "#6e768133",
-    "scrollbarSlider.hoverBackground": "#6e768145",
-    "scrollbarSlider.activeBackground": "#6e768187",
+    "scrollbarSlider.background": "#8b949e33",
+    "scrollbarSlider.hoverBackground": "#8b949e3d",
+    "scrollbarSlider.activeBackground": "#8b949e47",
     "editorOverviewRuler.border": "#010409",
+    "minimapSlider.background": "#8b949e33",
+    "minimapSlider.hoverBackground": "#8b949e3d",
+    "minimapSlider.activeBackground": "#8b949e47",
     "panel.background": "#010409",
--- base/themes/dark-dimmed.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/dark-dimmed.json	2023-01-05 03:28:04.932188186 +0000
@@ -143,6 +143,9 @@
     "scrollbar.shadow": "#545d6833",
-    "scrollbarSlider.background": "#636e7b33",
-    "scrollbarSlider.hoverBackground": "#636e7b45",
-    "scrollbarSlider.activeBackground": "#636e7b87",
+    "scrollbarSlider.background": "#76839033",
+    "scrollbarSlider.hoverBackground": "#7683903d",
+    "scrollbarSlider.activeBackground": "#76839047",
     "editorOverviewRuler.border": "#1c2128",
+    "minimapSlider.background": "#76839033",
+    "minimapSlider.hoverBackground": "#7683903d",
+    "minimapSlider.activeBackground": "#76839047",
     "panel.background": "#1c2128",
--- base/themes/dark-high-contrast.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/dark-high-contrast.json	2023-01-05 03:28:04.932188186 +0000
@@ -147,6 +147,9 @@
     "scrollbar.shadow": "#7a828e33",
-    "scrollbarSlider.background": "#9ea7b333",
-    "scrollbarSlider.hoverBackground": "#9ea7b345",
-    "scrollbarSlider.activeBackground": "#9ea7b387",
+    "scrollbarSlider.background": "#bdc4cc33",
+    "scrollbarSlider.hoverBackground": "#bdc4cc3d",
+    "scrollbarSlider.activeBackground": "#bdc4cc47",
     "editorOverviewRuler.border": "#010409",
+    "minimapSlider.background": "#bdc4cc33",
+    "minimapSlider.hoverBackground": "#bdc4cc3d",
+    "minimapSlider.activeBackground": "#bdc4cc47",
     "panel.background": "#010409",
--- base/themes/light-colorblind.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/light-colorblind.json	2023-01-05 03:28:04.932188186 +0000
@@ -144,5 +144,8 @@
     "scrollbarSlider.background": "#8c959f33",
-    "scrollbarSlider.hoverBackground": "#8c959f45",
-    "scrollbarSlider.activeBackground": "#8c959f87",
+    "scrollbarSlider.hoverBackground": "#8c959f3d",
+    "scrollbarSlider.activeBackground": "#8c959f47",
     "editorOverviewRuler.border": "#ffffff",
+    "minimapSlider.background": "#8c959f33",
+    "minimapSlider.hoverBackground": "#8c959f3d",
+    "minimapSlider.activeBackground": "#8c959f47",
     "panel.background": "#f6f8fa",
--- base/themes/light-default.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/light-default.json	2023-01-05 03:28:04.928188089 +0000
@@ -144,5 +144,8 @@
     "scrollbarSlider.background": "#8c959f33",
-    "scrollbarSlider.hoverBackground": "#8c959f45",
-    "scrollbarSlider.activeBackground": "#8c959f87",
+    "scrollbarSlider.hoverBackground": "#8c959f3d",
+    "scrollbarSlider.activeBackground": "#8c959f47",
     "editorOverviewRuler.border": "#ffffff",
+    "minimapSlider.background": "#8c959f33",
+    "minimapSlider.hoverBackground": "#8c959f3d",
+    "minimapSlider.activeBackground": "#8c959f47",
     "panel.background": "#f6f8fa",
--- base/themes/light-high-contrast.json	2023-01-05 03:28:08.140266681 +0000
+++ themes/light-high-contrast.json	2023-01-05 03:28:04.928188089 +0000
@@ -147,5 +147,8 @@
     "scrollbarSlider.background": "#88929d33",
-    "scrollbarSlider.hoverBackground": "#88929d45",
-    "scrollbarSlider.activeBackground": "#88929d87",
+    "scrollbarSlider.hoverBackground": "#88929d3d",
+    "scrollbarSlider.activeBackground": "#88929d47",
     "editorOverviewRuler.border": "#ffffff",
+    "minimapSlider.background": "#88929d33",
+    "minimapSlider.hoverBackground": "#88929d3d",
+    "minimapSlider.activeBackground": "#88929d47",
     "panel.background": "#ffffff",

@simurai simurai marked this pull request as ready for review January 5, 2023 03:27
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@simurai simurai merged commit eff8b22 into main Jan 5, 2023
@simurai simurai deleted the minimap branch January 5, 2023 08:56
@primer-css primer-css mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opacity of minimap slider is too low
2 participants