Quick improvements to #65 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simurai
added this to 🚧 Work in Progress
in 📦 GitHub theme release tracking
via automation
simurai
reviewed
Jun 26, 2020
src/theme.js
Outdated
| @@ -10,7 +10,8 @@ function getTheme({ style, name }) { | |||
|
|
|||
| const primer = getColors(style); | |||
|
|
|||
| const foreground = pick({ light: primer.gray[8], dark: primer.gray[7] }); | |||
| const nonEditorForeground = pick({ light: primer.gray[8], dark: primer.gray[7] }); | |||
There was a problem hiding this comment.
Should we call nonEditorForeground 👉 workbenchForeground instead? It seems that's how VS Code calls these two areas: https://code.visualstudio.com/docs/getstarted/themes#_customizing-a-color-theme
There was a problem hiding this comment.
Yeah good suggestion.
📦 GitHub theme release tracking
automation
moved this from 🚧 Work in Progress
to ✅ Approved for release
Jun 26, 2020
📦 GitHub theme release tracking
automation
moved this from ✅ Approved for release
to 💜 Done
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make future changes easier to different people especially if we consider adding a high contrast version of the theme.