Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepoints listing #128

Closed
masaeedu opened this issue Sep 28, 2016 · 2 comments
Closed

Codepoints listing #128

masaeedu opened this issue Sep 28, 2016 · 2 comments

Comments

@masaeedu
Copy link

This might just be me misunderstanding how github works, but I can't find the codepoints.json file you used to have in an earlier commit: https://github.com/primer/octicons/pull/100/files.

This is useful to have because it makes it less confusing to debug font issues and reason about what codepoints to include when consuming the library (e.g. see ryanoasis/nerd-fonts/issues/87).

@jonrohan
Copy link
Member

The codepoints.json file is in the latest release https://github.com/primer/octicons/blob/v4.3.0/lib/font/codepoints.json

But as of 5.0.0 #108 we're going to be deprecating support for the font file. On master right now is the unreleased 5.0 https://github.com/primer/octicons/blob/master/CHANGELOG.md#500

@dmitshur
Copy link
Contributor

Was this issue about codepoints listing (which is font-specific) or about keywords listing (which relates to Octicons in general, not font or SVG-specific)?

Based on the linked PR, which added "Keywords.json file that has an index of all octicons with alias names, I thought it was about keywords.json.

It looks like keywords.json is still there, it was just renamed to data.json:

https://github.com/primer/octicons/blob/master/lib/data.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants