Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0x2665 and 0x26a1 #87

Closed
minerva1129 opened this issue May 26, 2016 · 7 comments
Closed

0x2665 and 0x26a1 #87

minerva1129 opened this issue May 26, 2016 · 7 comments
Labels
Milestone

Comments

@minerva1129
Copy link

(I'm afraid my English may be hard to read, sorry...)
I want to use "heart(0x2665)" and "zap(0x26a1)" character, they are from octicons.
However, I can't find them in patched-fonts, but they exists in glyph-source-fonts/octicons.tff ...

@ryanoasis
Copy link
Owner

No worries (and by the way I can read it just fine 😄)

At first I thought this was likely due to the conflict between Octicons and Font Awesome ranges used (see: https://github.com/ryanoasis/nerd-fonts/blob/master/font-patcher#L215-L216)

However the Unicode points you mention are very different than most of Octicons (f000 and above)

It definitely looks like you have found a bug because right now the patcher is only taking into account Octicons from range f000 to f0db

Another one that seems to be missing as well is device-desktop f27c

Question: By the way are you using a 'complete' version font or just a variation with Octicons?

On the 'complete' version the Octicons glyph points do change because of the conflict with Font Awesome mentioned above^ so just something to keep in mind as well

@minerva1129
Copy link
Author

I'm using complete version. I did with --fontawesome --fontlinux --octicons --pomicons --powerline --powerlinextra.

@ryanoasis
Copy link
Owner

Thanks

@ryanoasis ryanoasis added this to the v0.8.1 milestone Jun 2, 2016
@ryanoasis
Copy link
Owner

This will more than likely be the next thing to be released.

@ryanoasis
Copy link
Owner

I was expecting to get to this quickly before v0.9.0 but that just didn't happen. Since I want to release v0.9.0 soon it makes to move this fix there.

A full rebuild of all fonts is needed anyway for this fix

@ryanoasis
Copy link
Owner

@minerva1129 This is fixed in 0.9.0 branch. Please give it a try if you can thanks. I will merge to master when ready

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants