Release 9.1.1 #324
Merged
Release 9.1.1 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for duplicate icon names and fail when two icons have the same name
jonrohan
approved these changes
Jun 21, 2019
dmitshur
added a commit
to shurcooL/octicon
that referenced
this pull request
Sep 30, 2019
Use a fixed Octicon width and height of 16 px, and simplify the generateOcticon and parseOcticon functions that do this. Change octicon.Height field type to float64 because some Octicons now have non-integer heights. See primer/octicons#346. Follows primer/octicons#324.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 Bug Fix
shield-lock[Patch] Re-naming shield duplicate icon聽#323 @ashygee