Octicons v2 👀 #370
Merged
Octicons v2 👀 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to support SVGs with multiple <path> elements
Namespace octicons v2 for use alongside v1
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/octicons/fvy8pvhnr |
Co-Authored-By: Jon Rohan <yes@jonrohan.codes>
Co-Authored-By: Jon Rohan <yes@jonrohan.codes>
* Save meter-16.svg * Save meter-16.svg * Optimize SVGs * Update changelog * Save meter-16.svg * Optimize SVGs Co-authored-by: Cole Bemis <actions@github.com>
* Save paintbrush-16.svg * Optimize SVGs * Save paintbrush-16.svg * Optimize SVGs * Update changelog * Save paintbrush-16.svg * Optimize SVGs Co-authored-by: Cole Bemis <actions@github.com>
* Save squirrel-16.svg * Optimize SVGs * Save squirrel-16.svg * Optimize SVGs * Save squirrel-16.svg * Optimize SVGs Co-authored-by: Cole Bemis <actions@github.com>
* Save browser-16.svg, bug-16.svg, repo-clone-16.svg, repo-pull-16.svg, device-camera-16.svg * Optimize SVGs Co-authored-by: Cole Bemis <actions@github.com>
* Update node package to handle 24px icons * Update docs * Finish updating docs * Update changelog
* Update package names in docs * Remove "v2" from package names * Update docs/content/packages/javascript.mdx
colebemis
commented
Jun 10, 2020
colebemis
commented
Jun 10, 2020
colebemis
commented
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this branch?
This
v2branch is where we'll do all the code updates for the Octicons v2 project. Keeping a long-lived feature branch like this allows us to update and publish new Octicons packages under different names (i.e.octicons→octicons-v2). Publishing new Octicons packages will allow us to have both new and old Octicons packages installed on dotcom simultaneously. Once we're ready to remove the Octicons feature flag from dotcom, we can merge this branch intomaster. Before merging into master, we'll need to remember to revert the package names (i.e.octicons-v2→octicons).🔍 All PRs merged into
v2(so far).Packages
octiconsocticons_v2octicons_helperocticons_v2_helperjekyll-octiconsjekyll-octicons_v2@primer/octicons@primer/octicons-v2@primer/octicons-react@primer/octicons-v2-reactHow to use this branch
v2v2if your changes are related.octicons_v2packages in dotcomHelpful links