Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP revamp primer.github.io #22

Closed
wants to merge 10 commits into from
Closed

WIP revamp primer.github.io #22

wants to merge 10 commits into from

Conversation

broccolini
Copy link
Member

@broccolini broccolini commented Jun 25, 2018

This is very very WIP! Don't review the code at this point, lots of placeholder styles and svgs so I could prototype out a new design. Pushing this up so I can get design and content feedback.

A bunch of stuff needs more work, such as:

  • responsive is a bit wonky in places
  • octicons illo needs to adapt for mobile
  • need illos for open-source section
  • add icons for social media
  • finish footer
  • not all links are correct or linked yet
  • not sure what to do with primer packages icons
  • match up package icons for octicons (figma may not be allowed & is bigger than the others)
  • is it too monotone? Try other colors or light version?
  • add some animations

➡️ current design
➡️ pages preview or new design

revamp_v1

@simurai
Copy link

simurai commented Jun 27, 2018

This looks slick. 😍

Also showing the example how one would author the markup is helpful. 👍 People can quickly see: "Ohh.. some BEM + atomic mix, great!"

Maybe something to consider adding: A section with a couple components. Just so people can see the "look and feel" without going to the docs/storyboard. Probably hard to decide which ones, but maybe buttons (can't miss them), form inputs, navigation controls or so. Although "Primer product" kinda needs to be on a white background, so not sure how that would feel in the middle of all the dark. Ohh.. maybe this: At the top or under "Packages" there is a [ product | marketing ] switch, choosing product would make the whole page white and would only show "Primer product" components on the page. That would also show people when you wanna use what. Definitely a "nice to have" that could be added at a later point.

@broccolini
Copy link
Member Author

Closing this as this got shipped in primer/primer.style#2

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants