Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash character on components link #138

Merged
merged 1 commit into from May 31, 2019

Conversation

gtsiolis
Copy link
Contributor

Following the changes in #131, and more specifically the addition in gtsiolis@067a8f8#diff-c597a4ae790d5db22417a1f6d19b0a04R32, this will remove the trailing slash character / on components link which now causes a 404 error.

Alternatively, or additionally, this could be fixed by allowing the trailing slash character / on such URLs.

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good short-term fix. Thanks. 🙇

I'll still make an issue about allowing trailing slashes in URLs.

@simurai simurai merged commit 832ebe8 into primer:master May 31, 2019
@gtsiolis gtsiolis deleted the remove-trailing-slash-character branch May 31, 2019 14:55
@gtsiolis
Copy link
Contributor Author

Indeed, allowing trailing slashes is more than good to have long-term!

Thanks again @simurai! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants