Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slash character on components link #138

Merged
merged 1 commit into from
May 31, 2019
Merged

Remove trailing slash character on components link #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Now's [path alias] feature allows us to serve multiple apps under a single domai
#### Path alias tips and tricks
Because of the way that Now's path alias feature works, separate apps need to be configured to serve all of their URLs under the same path as they're aliased to here. In other words, an app aliased to `/alias/**` will need to serve all of its content from `/alias/` rather than `/`. For Next.js apps, this means nesting all of your page content in `pages/<alias>/`. Serving static assets is trickier; you can see how we did it for [the components site][components] in [this pull request](https://github.com/primer/components/pull/238).

[components]: https://primer.style/components/
[components]: https://primer.style/components
[Now]: https://zeit.co/now
[Now GitHub app]: https://github.com/apps/now
[path alias]: https://zeit.co/docs/features/path-aliases
Expand Down
2 changes: 1 addition & 1 deletion src/Hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function Hero() {
Team
</LinkLight>{' '}
・
<LinkLight ml={2} fontSize={[0, 1, 2]} href="https://primer.style/components/">
<LinkLight ml={2} fontSize={[0, 1, 2]} href="https://primer.style/components">
Components
</LinkLight>{' '}
・
Expand Down