Add Primer CSS redirects #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rezrah
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
👍 Tested URLs and they work as described. Can't see regressions to any other site.
Just to check though @langermank... we're going to see 404's to any bookmarked Gatsby urls. Are we comfortable with that? Or should they be redirected to a primer.style/design page?
E.g. If someone has bookmarked this URL previously: /css/components/links/
|
We've decided to move forward with this limited set of redirects, and if it becomes an issue we will add high traffic redirects in addition to roots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatsby docs for Primer CSS have all moved to Storybook. This adds a root redirect to Storybook, but also tries to direct traffic for utility docs to /design.
Do I need to add a redirect for every single page in Primer CSS docs?
Testing
I pushed this to staging:
https://primerstyle-staging.azurewebsites.net/css should render Storybook
https://primerstyle-staging.azurewebsites.net/css/utilities should render /design site