Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated primer.style og image #76

Merged
merged 6 commits into from
Nov 2, 2018
Merged

Updated primer.style og image #76

merged 6 commits into from
Nov 2, 2018

Conversation

emilybrick
Copy link
Contributor

No description provided.

@emilybrick emilybrick added the status: wip work in progress label Oct 29, 2018
@vercel
Copy link

vercel bot commented Oct 29, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@emilybrick
Copy link
Contributor Author

screenshot 2018-10-29 14 22 50
s
screenshot 2018-10-29 14 24 59

@emilybrick emilybrick changed the title [WIP] Updated primer.style og image Updated primer.style og image Nov 1, 2018
@emilybrick emilybrick removed the status: wip work in progress label Nov 1, 2018
broccolini
broccolini approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@broccolini broccolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this works and we can always iterate on in future as we refine our style :)

jonrohan
jonrohan approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags look good 👍

@emilybrick emilybrick merged commit 8f43dc8 into master Nov 2, 2018
@emilybrick emilybrick deleted the og-img-update branch November 2, 2018 15:01
dkngyn pushed a commit to dkngyn/primer.style that referenced this pull request Jun 9, 2019
@emilybrick
Updated primer.style og image (primer#76)
e73bfeb 
* updated og image and tags

* fixed typo

* added space

* removed space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@broccolini broccolini broccolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilybrick @jonrohan @broccolini