Skip to content

Commit

Permalink
Tooltip: Take the position:absolute back and make sure the v1 and v…
Browse files Browse the repository at this point in the history
…2 ids are same for new docs (#4317)

* position absolute on the popover-open and make sure the v1 and v2 ids some for new docs

* take position absolute back all together - it is only a docs issue

* add changeset

* update changeset

* couldn't use the new changeset cli - marked the change as major! Take it back it is patch
  • Loading branch information
broccolinisoup committed Feb 28, 2024
1 parent 5d3fcd3 commit 0e744e2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/tall-spiders-pay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Tooltip: Take position:absolute back that was introduced in https://github.com/primer/react/pull/4250 since causing flickering issues and update v2 id to be the same with v1 for the new docs site.
2 changes: 1 addition & 1 deletion docs/content/TooltipV2.mdx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
componentId: tooltip_v2
componentId: tooltip
title: Tooltip v2
status: Beta
a11yReviewed: true
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/TooltipV2/Tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const StyledTooltip = styled.div`
/* Overriding the default popover styles */
display: none;
&[popover] {
position: absolute;
padding: 0.5em 0.75em;
width: max-content;
margin: auto;
Expand Down

0 comments on commit 0e744e2

Please sign in to comment.