Tooltip: Take the position:absolute back and make sure the v1 and v2 ids are same for new docs
#4317
Conversation
… some for new docs
🦋 Changeset detectedLatest commit: f08e78b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| @@ -23,7 +23,6 @@ const StyledTooltip = styled.div` | |||
| /* Overriding the default popover styles */ | |||
| display: none; | |||
| &[popover] { | |||
| position: absolute; | |||
There was a problem hiding this comment.
This change was introduced to in #4250 to fix an issue on the Tooltip V2 react docs but it ended up causing a problem at dotcom (specifically memex), flickering and shifting when the tooltip appears. Without this line, everything except the docs is working fine. I think the issue is not on the tooltip but on docs, maybe? I'd like to take this change back to unblock the version upgrade and can look into further later. Though, all react docs is going to be migrated over to the new docs and the way that examples are rendered differently (from stories) on the new site so I'll see if the same issue persistent on the new docs first.
There was a problem hiding this comment.
The docs problem happens because the examples come after the first scroll, so this is why we added position:absolute. However, when I removed the position:absolute the instances at dotcom that come after the the first scroll are still the same. Seems like taking it back will fix things and not introduce any other issues as well.
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| componentId: tooltip_v2 | |||
| componentId: tooltip | |||
There was a problem hiding this comment.
Found out from Cameron that to be able to consolidate the versions of the same component on the new docs site, the ids need to be the same.
broccolinisoup
changed the title
position:absolute back and make sure the v1 and v2 ids are same for new docs
…2 ids are same for new docs (#4317) * position absolute on the popover-open and make sure the v1 and v2 ids some for new docs * take position absolute back all together - it is only a docs issue * add changeset * update changeset * couldn't use the new changeset cli - marked the change as major! Take it back it is patch
position:absoluteon the tooltip element was introduced to in #4250 to fix an issue on the Tooltip V2 react docs (tooltip is not visible) but it ended up causing a problem at dotcom (specifically memex), flickering and shifting when the tooltip appears. Without this change, everything except the docs is working fine. I think the issue is not on the tooltip but on docs, maybe? I'd like to take this change back to unblock the version upgrade and can look into further later. Though, all react docs is going to be migrated over to the new docs and the way that examples are rendered differently (from stories) on the new site so I'll see if the same issue persistent on the new docs first.Changelog
New
Changed
Removed
position: absolutefrom the tooltip element.Rollout strategy
Testing & Reviewing
Merge checklist