Skip to content

Commit

Permalink
fix(bundle): remove inline @github deps (#2404)
Browse files Browse the repository at this point in the history
* fix(bundle): remove inline @github deps

* chore: update package.json files

* chore: add changeset
  • Loading branch information
joshblack committed Oct 7, 2022
1 parent ba7cf92 commit 1d1d07b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/pink-jokes-destroy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Update bundle to not inline @github dependencies
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"codemods",
"dist",
"lib",
"lib/node_modules",
"lib-esm",
"index.d.ts",
"drafts/package.json",
Expand Down
10 changes: 3 additions & 7 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ const baseConfig = {
babelHelpers: 'inline',
babelrc: false
}),
commonjs(),
resolve({
extensions
}),
commonjs()
})
]
}

Expand All @@ -69,11 +69,7 @@ export default [
// CommonJS
{
...baseConfig,
external: isExternal(
external.filter(id => {
return !id.startsWith('@github')
})
),
external: isExternal(external),
output: {
dir: 'lib',
format: 'commonjs',
Expand Down

0 comments on commit 1d1d07b

Please sign in to comment.