Dialog v1: Fix title font family (#4246)

* don't need to set fontFamily, inherit it * Create hot-hounds-speak.md * test(vrt): update snapshots --------- Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
primer · Feb 12, 2024 · 2aced1c · 2aced1c
1 parent 236fa34
commit 2aced1c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/hot-hounds-speak.md b/.changeset/hot-hounds-speak.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Dialog v1: Fix font-family for title
diff --git a/packages/react/src/Dialog.stories.tsx b/packages/react/src/Dialog.stories.tsx
@@ -28,7 +28,7 @@ export const Default = () => {
         <div data-testid="inner">
           <Dialog.Header id="header">Title</Dialog.Header>
           <Box p={3}>
-            <Text fontFamily="sans-serif">Some content</Text>
+            <Text>Some content</Text>
           </Box>
         </div>
       </Dialog>

diff --git a/packages/react/src/Dialog.tsx b/packages/react/src/Dialog.tsx
@@ -57,7 +57,7 @@ export type DialogHeaderProps = ComponentProps<typeof DialogHeaderBase>
 function DialogHeader({theme, children, backgroundColor = 'canvas.subtle', ...rest}: DialogHeaderProps) {
   if (React.Children.toArray(children).every(ch => typeof ch === 'string')) {
     children = (
-      <Text theme={theme} color="fg.default" fontSize={1} fontWeight="bold" fontFamily="sans-serif">
+      <Text fontSize={1} fontWeight="bold">
         {children}
       </Text>
     )