Dialog v1: Fix title font family #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
joshblack
approved these changes
Feb 9, 2024
size-limit report 📦
|
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* don't need to set fontFamily, inherit it * Create hot-hounds-speak.md * test(vrt): update snapshots --------- Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textcomponent inDialogv1 is not properly renderingfont-family#4244Not sure about the historical context of this code, but I think we can let the Dialog get it styles by inherit them