Support ReactNode in ActionMenu.Overlay (#2168) (#2188)

* Supporting ReactNode type for ActionMenu children * Fixing spacing * Updating ActionMenu.Overlay props docs * Adding changeset Co-authored-by: Joshua Rush <jdrush89@gmail.com> Co-authored-by: Cole Bemis <colebemis@github.com>
primer · Aug 25, 2022 · 8fc2e42 · 8fc2e42
1 parent 3a29eb3
commit 8fc2e42
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/shiny-hairs-wait.md b/.changeset/shiny-hairs-wait.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Support React.ReactNode as child type in ActionMenu.Overlay
diff --git a/docs/content/ActionMenu.mdx b/docs/content/ActionMenu.mdx
@@ -342,7 +342,7 @@ render(
 ### ActionMenu.Overlay
 
 <PropsTable>
-  <PropsTableRow name="children" required type="React.ReactElement | React.ReactElement[]" />
+  <PropsTableRow name="children" required type="React.ReactNode" />
   <PropsTableRow name="align" type="start | center | end" defaultValue="start" />
   <PropsTablePassthroughPropsRow
     elementName="Overlay"

diff --git a/src/ActionMenu.tsx b/src/ActionMenu.tsx
@@ -102,7 +102,7 @@ type MenuOverlayProps = Partial<OverlayProps> &
     /**
      * Recommended: `ActionList`
      */
-    children: React.ReactElement[] | React.ReactElement
+    children: React.ReactNode
   }
 const Overlay: React.FC<React.PropsWithChildren<MenuOverlayProps>> = ({children, align = 'start', ...overlayProps}) => {
   // we typecast anchorRef as required instead of optional