Support ReactNode in ActionMenu.Overlay #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supporting ReactNode type for ActionMenu children * Fixing spacing * Updating ActionMenu.Overlay props docs * Adding changeset
🦋 Changeset detectedLatest commit: 23ee0fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
6 tasks
|
@jdrush89 A canary version is published for each commit
you can install this one by running |
|
@siddharthkp I tested with the canary package in a memex codespace and all looks good, I'm able to specify false and null as Overlay children and everything's working as expected. |
jdrush89
approved these changes
Aug 15, 2022
|
That's perfect! I'll merge this tomorrow and add it to the next release :) |
joshblack
approved these changes
Aug 16, 2022
colebemis
approved these changes
Aug 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from #2168 by @jdrush89
Describe your changes here.
Add support for ReactNode as the child type in ActionMenu.Overlay so that conditional children can be rendered within an overlay.
Closes #2067
Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.