-
Notifications
You must be signed in to change notification settings - Fork 529
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
UnderlineNav overflow behaviour implementation (#2297)
* initial impl for overflow behaviour * scroll behaviour initial commit - wip * overflow and scroll behaviour and styles * introduce scroll arrow buttons * scroll behaviour in dept * revert back stories to original state * Fix types and align/variant issues * Use separate component for arrow buttons * fade out affects on scroll ends * type issues and some refactor * style refactor & theming & scrollIntoView from primer behaviour * Update documentation * Update documentation * add changeset * remove scroll story until finding a way to simulate coarse pointer * add single variant selection to ActionList * take more button into account when calculating & code review feedback * remove scroll behaviour - due to accessibility concerns * hover state remove on mobile and improvments on more btn functionality * remove prop controls and align story * update tests and docs * update docs * overflow effect improvments * Revert "remove scroll behaviour - due to accessibility concerns" This reverts commit eade73d. * scroll behaviour feedback * update tests * keyboard navigation tab through * Update .changeset/sweet-eggs-complain.md Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/drafts/UnderlineNav2.mdx Co-authored-by: Pavithra Kodmad <pksjce@github.com> Co-authored-by: Cole Bemis <colebemis@github.com>
- Loading branch information
1 parent
33ba836
commit cad2bc0
Showing
10 changed files
with
691 additions
and
281 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@primer/react': minor | ||
--- | ||
|
||
UnderlineNav2: Introducing overflow behavior for fine and coarse pointer devices |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.