Default portal containers created by primer are absolutely positioned at 0,0 #1398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three styling rules to the primer-created portal container root:
position: absolute, top: 0, left: 0
. This doesn't add any styling to either roots provided viaregisterPortalRoot
or roots provided by placing an element with id__primerPortalRoot__
in the DOM.Why?
Compared to statically positioning a portal root after body content, absolutely positioning a portal root relative to the body will lead to more stable overlay positioning across DOM changes.
See also #1395
Screenshots
N/A
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.