Add displayName to all components #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
changed the base branch from
release-0.0.12-beta
to
release-0.0.13-beta
|
🤔 Wonder why all these live editor commits are showing up as diffs when they were merged into master in 0.0.12? |
|
Yeah, I'm doing a |
shawnbot
force-pushed
the
add-displayname
branch
from
1818474
to
cb2129a
Compare
4 tasks
shawnbot
added
enhancement
jonrohan
approved these changes
Aug 3, 2018
shawnbot
moved this from v1.0.1-beta To Do
to 🙇♀️ WIP
in Primer Components release tracking 📋
shawnbot
commented
Aug 6, 2018
.eslintrc.json
Outdated
| @@ -5,6 +5,6 @@ | |||
| "plugin:jsx-a11y/recommended" | |||
| ], | |||
| "rules": { | |||
| "no-unused-vars": ["error", {"args": "after-used"}] | |||
| "import/no-namespace": "warn" | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Okay, conflicts fixed. This should be ready to include in #182. |
shawnbot
moved this from 🙇♀️ WIP
to 1.0.0-beta Completed
in Primer Components release tracking 📋
emplums
moved this from 2.0.0-beta Completed
to 🚢Published
in Primer Components release tracking 📋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141.