Adding FilterList and FilterListItem #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emplums
approved these changes
Aug 1, 2018
src/FilterListItem.js
Outdated
|
|
||
| return ( | ||
| <Tag className={classes} {...rest}> | ||
| {countComponent} |
There was a problem hiding this comment.
Instead of returning undefined here you could do {count && getCountComponent(count)} or {count && countComponent}
src/FilterListItem.js
Outdated
| ) | ||
| } | ||
|
|
||
| FilterListItem.displayName = 'FilterListItem' |
shawnbot
reviewed
Aug 2, 2018
emplums
moved this from Backlog
to 1.0.0-beta Completed
in Primer Components release tracking 馃搵
emplums
moved this from 2.0.0-beta Completed
to 馃殺Published
in Primer Components release tracking 馃搵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137
This PR introduces
FilterListandFilterListItemto create the side nav filters seen here https://styleguide.github.com/primer/components/navigation/#filter-listI modeled this API almost exactly like
UnderlineNavHowever there are a few key differences and less complexity.Differences
FilterListrenders with a<ul>and<li>elements. I usedFilterListto wrap it's childrenFilterListItemin<li>. I did this on FilterList instead of FilterListItem because none of the appropriate classes go on the li and I think they're only needed in context of FilterListFilterListdoesn't have any extra actions alignmentsFilterListhas asmalloption that condenses the listFilterListItemhas acountprop that will render the item count.I'm ready for review on this 馃憤