Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @primer/behaviors to 1.1.0 #1877

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 21, 2022

Release branch: primer/behaviors#59

tl;dr: accessibility improvements for focusTrap

For components that use focus trap, when the component is open, the first item will have focus. The method of opening the menu (mouse click or keypress) does not matter.

Components that use focusTrap:

  • Dialog (and by extension: ConfirmationDialog)
  • AnchoredOverlay (and by extension: ActionMenu, ActionMenu2, DropdownMenu, DropdownMenu2, SelectPanel, Autocomplete)

@siddharthkp siddharthkp requested review from a team and rezrah February 21, 2022 15:51
@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2022

🦋 Changeset detected

Latest commit: 807412c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 62.62 KB (+0.04% 🔺)
dist/browser.umd.js 63.01 KB (+0.04% 🔺)

@siddharthkp siddharthkp merged commit 50fa988 into main Feb 21, 2022
@siddharthkp siddharthkp deleted the siddharth/upgrade-behaviors-1.1.0 branch February 21, 2022 16:09
@primer-css primer-css mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants