Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentedControl - make fullWidth prop responsive #2191

Merged
merged 13 commits into from
Aug 5, 2022

Conversation

mperrotti
Copy link
Contributor

In addition to making fullWidth a responsive prop, I've removed the useMatchMedia hook, and replaced it's usage with the new useResponsive hook.

Merge checklist

  • [n/a] Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and rezrah July 26, 2022 19:55
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: ddd7786

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mperrotti mperrotti changed the title SegmentedControl - make fullWidth prop is responsive SegmentedControl - make fullWidth prop responsive Jul 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 72.9 KB (0%)
dist/browser.umd.js 73.27 KB (0%)

@mperrotti mperrotti temporarily deployed to github-pages July 26, 2022 20:00 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨ Left a few non-blocking comments

docs/content/SegmentedControl.mdx Outdated Show resolved Hide resolved
docs/content/SegmentedControl.mdx Outdated Show resolved Hide resolved
src/SegmentedControl/SegmentedControl.tsx Outdated Show resolved Hide resolved
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
@mperrotti mperrotti temporarily deployed to github-pages August 1, 2022 17:42 Inactive
@mperrotti mperrotti temporarily deployed to needs-approval August 1, 2022 19:18 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 1, 2022 19:24 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 2, 2022 13:46 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 2, 2022 16:20 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 2, 2022 19:20 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 3, 2022 15:14 Inactive
@mperrotti mperrotti temporarily deployed to needs-approval August 4, 2022 13:11 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 4, 2022 13:18 Inactive
@mperrotti mperrotti temporarily deployed to needs-approval August 5, 2022 14:43 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 5, 2022 14:48 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 5, 2022 14:50 Inactive
@mperrotti mperrotti merged commit 7edf134 into main Aug 5, 2022
@mperrotti mperrotti deleted the mp/segmented-control-fullWidth-responsive branch August 5, 2022 15:17
@primer-css primer-css mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants