-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SegmentedControl - make fullWidth prop responsive #2191
Conversation
…new useResponsive hook
🦋 Changeset detectedLatest commit: ddd7786 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ✨ Left a few non-blocking comments
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
In addition to making
fullWidth
a responsive prop, I've removed theuseMatchMedia
hook, and replaced it's usage with the newuseResponsive
hook.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.