Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows checkout by removing unsupported colon in filename #2615

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

Swiftwork
Copy link
Contributor

Describe your changes here.

Refactored scripts/test:e2e to scripts/test-e2e and updated documentation. Reason for change is that colon's in filenames aren't supported in Windows. git clone works but git checkout will fail with error:

error: invalid path 'script/test:e2e'

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@Swiftwork Swiftwork requested review from a team and siddharthkp November 25, 2022 15:04
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

🦋 Changeset detected

Latest commit: 6cbdbcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Swiftwork!

@colebemis colebemis added skip changeset This change does not need a changelog and removed skip changeset This change does not need a changelog labels Nov 28, 2022
@colebemis colebemis enabled auto-merge (squash) November 30, 2022 18:05
@colebemis colebemis merged commit a745569 into primer:main Nov 30, 2022
@primer-css primer-css mentioned this pull request Nov 30, 2022
@Swiftwork Swiftwork deleted the fix/colon-filename-unsupported branch November 30, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants