move defaultProps to function defaults #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad06caa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
requested review from
broccolinisoup and
colebemis
and removed request for
JoshBowdenConcepts
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-actions
bot
requested a deployment
to
storybook-preview-2759
Merged
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This was referenced Jan 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating all non-deprecated components that use
defaultPropsto stop using it and using function defaults instead.As described in the issue below,
defaultPropsis going to be deprecated so it'd be nice to be clear of it before the new React version is released.Closes #2758
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.