Token: Omit onResize
and onResizeCapture
methods from the interface as they cause type issues in React 18
#2760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token
component causes type issues on memex (ref) and blocking the release.It might be because React 18 types differ from React 17 and
onResize
andonResizeCapture
methods are included in the expansion in 18. This is a temporary solution until we know why this causes issues.Thanks so much to @joshblack for figuring out the issue and proposing a solution 🙏🏼
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.