2909 splitpagelayoutpane accepts an id but doesnt apply it #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea540cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
approved these changes
Mar 1, 2023
| @@ -736,6 +736,7 @@ const Pane = React.forwardRef<HTMLDivElement, React.PropsWithChildren<PageLayout | |||
| '--pane-max-width-diff': '959px', | |||
| }, | |||
| })} | |||
| {...(id && {id: paneId})} | |||
There was a problem hiding this comment.
How do you feel about simplifying to this?
Suggested change
| {...(id && {id: paneId})} | |
| id={id} |
If id is undefined, it won't pass id to the underlying component.
If id is defined, paneId and id will be the same, so we can use either.
green6erry
deleted the
2909-splitpagelayoutpane-accepts-an-id-but-doesnt-apply-it
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here - PageLayout/SplitPageLayout.Pane component is given an
idattribute, it is applied to the component when rendered.Closes #2909 (type the issue number after # if applicable; otherwise remove this line)
Screenshots
Please provide before/after screenshots for any visual changes
This is just showing the updated story where the id can be passed to the PageLayout/SplitPageLayout.Pane component
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.